Skip to content

fix: Redact Authorization header before sending events to Sentry #4164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamescrosswell merged 8 commits into from
May 8, 2025
Merged

fix: Redact Authorization header before sending events to Sentry #4164

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
24037a1
fix: Never capture authorization headers (even if SendDefaultPii is t…
jamescrosswell May 4, 2025
5825a24
Redact rather than skip Authorization headers
jamescrosswell May 5, 2025
bab48d3
Format code
getsentry-bot May 5, 2025
a47c989
Merge branch 'main' into exclude-auth-cookies
jamescrosswell May 6, 2025
fe4d9cb
Update RedactedHeaders.cs
jamescrosswell May 7, 2025
3d62f93
Review feedback
jamescrosswell May 7, 2025
5aef44f
Merge branch 'main' into exclude-auth-cookies
jamescrosswell May 7, 2025
f42a3a5
Update CHANGELOG.md
jamescrosswell May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Format code
  • Loading branch information
@getsentry-bot
getsentry-bot committed May 5, 2025
commit bab48d3a19aca6e4ba93d63dc8b095cfed01cc77
2 changes: 1 addition & 1 deletion src/Sentry/Protocol/Response.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public sealed class Response : ISentryJsonSerializable, ICloneable<Response>, IU
/// <remarks>
/// If a header appears multiple times it needs to be merged according to the HTTP standard for header merging.
/// </remarks>
public IDictionary<string, string> Headers => InternalHeaders ??= new ();
public IDictionary<string, string> Headers => InternalHeaders ??= new();

/// <summary>
/// Gets or sets the HTTP Status response code
Expand Down
2 changes: 1 addition & 1 deletion src/Sentry/SentryRequest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ public sealed class SentryRequest : ISentryJsonSerializable
/// If a header appears multiple times it needs to be merged according to the HTTP standard for header merging.
/// </remarks>
/// <value>The headers.</value>
public IDictionary<string, string> Headers => InternalHeaders ??= new ();
public IDictionary<string, string> Headers => InternalHeaders ??= new();

/// <summary>
/// Gets or sets the optional environment data.
Expand Down