Skip to content

Added email validation to CaptureFeedback methods #4284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamescrosswell merged 9 commits into from
Jun 18, 2025
Merged

Added email validation to CaptureFeedback methods #4284

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a325003
Added email validation to CaptureFeedback methods
jamescrosswell Jun 16, 2025
c2bd973
Update CHANGELOG.md
jamescrosswell Jun 16, 2025
b60c9e0
Format code
getsentry-bot Jun 16, 2025
e37422f
Review feedback
jamescrosswell Jun 16, 2025
dd924e5
Scrub email instead of dropping feedback entirely
jamescrosswell Jun 16, 2025
292b392
Update CHANGELOG.md
jamescrosswell Jun 18, 2025
2448c9e
Made EmailValidator more generic / rigorous
jamescrosswell Jun 18, 2025
b8c2018
Merge branch 'feedback-email-validation' of github.com:getsentry/sent…
jamescrosswell Jun 18, 2025
605413a
Format code
getsentry-bot Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update CHANGELOG.md
  • Loading branch information
@jamescrosswell
jamescrosswell authored Jun 18, 2025
commit 292b3929a5fc31a38d0e917a4ac21082aacc7928
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

- The HTTP instrumentation uses the span created for the outgoing request in the sentry-trace header, fixing the parent-child relationship between client and server ([#4264](https://github.com/getsentry/sentry-dotnet/pull/4264))
- InvalidOperationException sending attachments on Android with LLVM enabled ([#4276](https://github.com/getsentry/sentry-dotnet/pull/4276))
- When CaptureFeedback methods are called with invalid email addresses, a warning is now logged if Debug mode is enabled (explaining why the feedback has been dropped) ([#4284](https://github.com/getsentry/sentry-dotnet/pull/4284))
- When CaptureFeedback methods are called with invalid email addresses, the email address will be removed and, if Debug mode is enabled, a warning will be logged. This is done to avoid losing the Feedback altogether (Sentry would reject Feedback that has an invalid email address) ([#4284](https://github.com/getsentry/sentry-dotnet/pull/4284))

### Dependencies

Expand Down
Loading