Skip to content

fix: Source context for class libraries when running on Android in Release mode #4294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamescrosswell merged 51 commits into from
Jul 24, 2025
Merged

fix: Source context for class libraries when running on Android in Release mode #4294

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
d97b4cb
fix: Source context for class libraries when running on Android in Re…
jamescrosswell Jun 19, 2025
99ecda7
Update CHANGELOG.md
jamescrosswell Jun 19, 2025
eaf4382
Merge branch 'main' into multi-project-maui
jamescrosswell Jun 19, 2025
77a3836
Merge branch 'main' into multi-project-maui
jamescrosswell Jul 8, 2025
0fae5db
Update CHANGELOG.md
jamescrosswell Jul 8, 2025
d6366f6
Merge branch 'main' into multi-project-maui
jamescrosswell Jul 8, 2025
68674b6
Merge branch 'main' into multi-project-maui
jamescrosswell Jul 8, 2025
be7ea6e
Update AndroidAssemblyStoreReaderV2.cs
jamescrosswell Jul 8, 2025
057489f
Update AndroidAssemblyStoreReaderV2.cs
jamescrosswell Jul 8, 2025
19f22ec
Update CachingTransportTests.cs
jamescrosswell Jul 9, 2025
50ab8f4
Merge branch 'main' into multi-project-maui
jamescrosswell Jul 12, 2025
e322bef
Merge branch 'main' into multi-project-maui
jamescrosswell Jul 13, 2025
544b354
Update Sentry.Maui.Device.TestApp.csproj
jamescrosswell Jul 13, 2025
6dd5218
Update device-tests-android.yml
jamescrosswell Jul 14, 2025
ce0a859
Exclude SentryMauiOptionsTests (testing)
jamescrosswell Jul 17, 2025
76ae028
Merge branch 'main' into multi-project-maui
jamescrosswell Jul 17, 2025
a33c654
Update CHANGELOG.md
jamescrosswell Jul 17, 2025
2b15fda
Try FakeReliableNetworkStatusListener in SentryMauiOptionsTests
jamescrosswell Jul 17, 2025
982ffe4
Disable all but one SentryMauiOptionsTests
jamescrosswell Jul 17, 2025
d68676c
Update SentryMauiOptionsTests.cs
jamescrosswell Jul 18, 2025
3a36d99
Merge branch 'main' into multi-project-maui
jamescrosswell Jul 18, 2025
849d704
Try skipping event binders
jamescrosswell Jul 18, 2025
7bd5069
Update CachingTransportTests.cs
jamescrosswell Jul 18, 2025
a527401
Try removing callbacks
jamescrosswell Jul 20, 2025
882e6cc
Merge branch 'main' into multi-project-maui
jamescrosswell Jul 20, 2025
2d2e1b2
Moved default event binders into SentryMauiAppBuilderExtensions
jamescrosswell Jul 21, 2025
c58d2d9
Uncomment the other device tests again
jamescrosswell Jul 21, 2025
6686e9e
Renamed InjectedEventBinders to IntegrationEventBinders
jamescrosswell Jul 21, 2025
11f09e4
Update SentryMauiAppBuilderExtensions.cs
jamescrosswell Jul 21, 2025
8689ce3
Try commenting out MauiCommunityToolkitMvvmEventsBinderTests
jamescrosswell Jul 21, 2025
bc87f3e
Update Startup.cs
jamescrosswell Jul 21, 2025
88daf10
Back to just the SentrySdkTests
jamescrosswell Jul 21, 2025
eed38d9
Added LogLevelExtensionsTests & AndroidAssemblyReaderTests
jamescrosswell Jul 21, 2025
053831f
Added SentryMauiOptionsTests back again
jamescrosswell Jul 21, 2025
ba8e335
No SentryMauiOptionsTests but MauiCommunityToolkitMvvmEventsBinderTests
jamescrosswell Jul 21, 2025
b3fea09
Include half the Sentry.Maui.Tests
jamescrosswell Jul 21, 2025
00ff1f2
Disable the other half
jamescrosswell Jul 21, 2025
ac86208
Just api and options tests
jamescrosswell Jul 21, 2025
e8375ab
Update Sentry.Maui.Tests.csproj
jamescrosswell Jul 21, 2025
1a080dd
Include logcat and screenshot tests
jamescrosswell Jul 22, 2025
2d954bc
Add SentryMauiAppBuilderExtensionsTests
jamescrosswell Jul 22, 2025
f0d9a3c
Added MauiNetworkStatusListenerTests and BreadcrumbEventTests
jamescrosswell Jul 22, 2025
1dde8f7
Added back MauiEventsBinderTests
jamescrosswell Jul 22, 2025
acc5518
Reintroduce button binders
jamescrosswell Jul 22, 2025
614b33e
Reintroduce MauiGestureRecognizerEventsBinderTests
jamescrosswell Jul 22, 2025
da061fc
Reintroduce MauiVisualElementEventsBinderTests
jamescrosswell Jul 22, 2025
527e09e
Reintroduce SentryMauiLogcatsTests
jamescrosswell Jul 23, 2025
ce94206
Reintroduce CaptureException_RemoveScreenshot_NotContainsScreenshotAt…
jamescrosswell Jul 23, 2025
9346258
Reintroduce CaptureException_BeforeCaptureScreenshot_DisableCaptureAsync
jamescrosswell Jul 23, 2025
cb19808
Update MauiImageButtonEventsBinder.cs
jamescrosswell Jul 23, 2025
4e12078
Reintroduce/tweak CaptureException_AttachScreenshot_Threadsafe
jamescrosswell Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Include half the Sentry.Maui.Tests
  • Loading branch information
@jamescrosswell
jamescrosswell committed Jul 21, 2025
commit b3fea0961d183da60249e0e1c33c32ab3ba5718a
2 changes: 1 addition & 1 deletion test/Sentry.Maui.Device.TestApp/Startup.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
[
typeof(Sentry.Tests.SentrySdkTests).Assembly,
typeof(Sentry.Extensions.Logging.Tests.LogLevelExtensionsTests).Assembly,
// typeof(Sentry.Maui.Tests.SentryMauiOptionsTests).Assembly,
typeof(Sentry.Maui.Tests.SentryMauiOptionsTests).Assembly,

Check failure on line 17 in test/Sentry.Maui.Device.TestApp/Startup.cs

View workflow job for this annotation

GitHub Actions / Build (net9.0) 

The type or namespace name 'SentryMauiOptionsTests' does not exist in the namespace 'Sentry.Maui.Tests' (are you missing an assembly reference?)

Check failure on line 17 in test/Sentry.Maui.Device.TestApp/Startup.cs

View workflow job for this annotation

GitHub Actions / Build (net9.0) 

The type or namespace name 'SentryMauiOptionsTests' does not exist in the namespace 'Sentry.Maui.Tests' (are you missing an assembly reference?)
#if NET9_0_OR_GREATER
typeof(Sentry.Maui.CommunityToolkit.Mvvm.Tests.MauiCommunityToolkitMvvmEventsBinderTests).Assembly,
#endif
Expand Down
26 changes: 26 additions & 0 deletions test/Sentry.Maui.Tests/Sentry.Maui.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,30 @@
<PackageReference Include="Microsoft.Maui.Controls" Version="$(MauiVersion)" />
</ItemGroup>

<!-- Disable all test files - comment out specific lines to re-enable tests -->
<ItemGroup>
<Compile Remove="ApiApprovalTests.verify.cs" />
<Compile Remove="BindableSentryMauiOptionsTests.cs" />
<Compile Remove="BreadcrumbEventTests.cs" />
<Compile Remove="SentryMauiAppBuilderExtensionsTests.cs" />
<Compile Remove="SentryMauiAppBuilderExtensionsTests.Android.cs" />
<Compile Remove="SentryMauiAppBuilderExtensionsTests.Cocoa.cs" />
<Compile Remove="SentryMauiOptionsTests.cs" />
<Compile Remove="SentryMauiLogcatsTests.cs" />
<Compile Remove="SentryMauiScreenshotTests.cs" />
<!-- <Compile Remove="MauiButtonEventsBinderTests.cs" />-->
<!-- <Compile Remove="MauiEventsBinderFixture.cs" />-->
<!-- <Compile Remove="MauiEventsBinderTests.Application.cs" />-->
<!-- <Compile Remove="MauiEventsBinderTests.Element.cs" />-->
<!-- <Compile Remove="MauiEventsBinderTests.Page.cs" />-->
<!-- <Compile Remove="MauiEventsBinderTests.Shell.cs" />-->
<!-- <Compile Remove="MauiEventsBinderTests.VisualElement.cs" />-->
<!-- <Compile Remove="MauiEventsBinderTests.Window.cs" />-->
<!-- <Compile Remove="MauiEventsBinderTests.cs" />-->
<!-- <Compile Remove="MauiGestureRecognizerEventsBinderTests.cs" />-->
<!-- <Compile Remove="MauiImageButtonEventsBinderTests.cs" />-->
<!-- <Compile Remove="MauiNetworkStatusListenerTests.cs" />-->
<!-- <Compile Remove="MauiVisualElementEventsBinderTests.cs" />-->
</ItemGroup>

</Project>
Loading