Skip to content

fix: Crontab validation when capturing checkins #4314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamescrosswell merged 4 commits into from
Jul 1, 2025
Merged

fix: Crontab validation when capturing checkins #4314

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1e9d22b
Fix Directory.Build.targets when using SentryNoMobile.slnf
jamescrosswell Jun 29, 2025
447494e
fix: Crontab validation when capturing checkins
jamescrosswell Jun 29, 2025
6c84e7e
Update CHANGELOG.md
jamescrosswell Jun 29, 2025
825dd0b
Fixed step value validation
jamescrosswell Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix Directory.Build.targets when using SentryNoMobile.slnf 
#skip-changelog
  • Loading branch information
@jamescrosswell
jamescrosswell committed Jun 29, 2025
commit 1e9d22bed0767cbdd1c32d652edf1e7f964fc75c
4 changes: 2 additions & 2 deletions samples/Directory.Build.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

<Target Name="GenerateSharedDsnConstant"
BeforeTargets="BeforeCompile"
Condition=" '$(SENTRY_DSN)' != '' and '$(PlatformIsMobile)' == 'true'">
Condition="'$(SENTRY_DSN)' != ''">

<Message Text="Generating shared EnvironmentVariables.g.cs with embedded DSN..." Importance="High" />

Expand All @@ -25,7 +25,7 @@ namespace Sentry.Samples%3B
internal static class EnvironmentVariables
{
/// &lt;summary&gt;
/// To make things easier for the SDK maintainers we have a custom build target that writes the
/// To make things easier for the SDK maintainers, we have a custom build target that writes the
/// SENTRY_DSN environment variable into an EnvironmentVariables class that is available for mobile
/// targets. This allows us to share one DSN defined in the ENV across desktop and mobile samples.
/// Generally, you won't want to do this in your own mobile projects though - you should set the DSN
Expand Down
Loading