Skip to content

fix: Remove AppDomain.CurrentDomain.ProcessExit hook on shutdown #4323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamescrosswell merged 7 commits into from
Jul 9, 2025
Merged

fix: Remove AppDomain.CurrentDomain.ProcessExit hook on shutdown #4323

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ee67ed7
fix: Remove AppDomain.CurrentDomain.ProcessExit hook on shutdown
jamescrosswell Jul 6, 2025
df5cf45
Unit tests
jamescrosswell Jul 7, 2025
0e5e8d1
Update CHANGELOG.md
jamescrosswell Jul 7, 2025
6af0c0f
Format code
getsentry-bot Jul 7, 2025
a8d2bb7
Merge branch 'main' into process-exit-cleanup
jamescrosswell Jul 8, 2025
6afe45d
Replaced ITidySdkIntegration with IDisposable
jamescrosswell Jul 8, 2025
daec7ab
Format code
getsentry-bot Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Format code
  • Loading branch information
@getsentry-bot
getsentry-bot committed Jul 7, 2025
commit 6af0c0f199e40afadd255b2b8c39815b6f4f8b7c
2 changes: 1 addition & 1 deletion src/Sentry/Integrations/ITidySdkIntegration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ namespace Sentry.Integrations;
/// allows us to add some cleanup logic as an internal interface. We can move this to <see cref="ISdkIntegration"/>
/// in the next major release.
/// </summary>
internal interface ITidySdkIntegration: ISdkIntegration
internal interface ITidySdkIntegration : ISdkIntegration
{
/// <summary>
/// Performs any necessary cleanup for the integration
Expand Down
2 changes: 1 addition & 1 deletion src/Sentry/Internal/Hub.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -782,7 +782,7 @@ public void Dispose()
{
try
{
integration.Cleanup();
integration.Cleanup();
}
catch (Exception e)
{
Expand Down