Skip to content

chore: Tidy up the source generator in tests and samples #4344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamescrosswell merged 3 commits into from
Jul 14, 2025
Merged

chore: Tidy up the source generator in tests and samples #4344

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1329dd7
chore: Tidy up the source generator in tests and samples
jamescrosswell Jul 13, 2025
fba5463
Verify tests
jamescrosswell Jul 13, 2025
71edc17
Update ApiApprovalTests.Run.Net4_8.verified.txt
getsentry-bot Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
chore: Tidy up the source generator in tests and samples 
#skip-changelog
  • Loading branch information
@jamescrosswell
jamescrosswell committed Jul 13, 2025
commit 1329dd7e470cdfd98a5d58c23d973c9c11d5e39e
7 changes: 7 additions & 0 deletions samples/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,11 @@
<PropertyGroup Condition="'$(Configuration)' == 'Release' And $([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) == 'ios'">
<MtouchUseLlvm>false</MtouchUseLlvm>
</PropertyGroup>

<ItemGroup>
<!-- So the source generators work for our samples... SDK users wouldn't need to do this -->
<ProjectReference Include="$(MSBuildThisFileDirectory)..\src\Sentry.SourceGenerators\Sentry.SourceGenerators.csproj"
OutputItemType="Analyzer"
ReferenceOutputAssembly="false"/>
</ItemGroup>
</Project>
3 changes: 0 additions & 3 deletions samples/Sentry.Samples.Android/Sentry.Samples.Android.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@
</PropertyGroup>

<ItemGroup>
<ProjectReference Include="..\..\src\Sentry.SourceGenerators\Sentry.SourceGenerators.csproj"
OutputItemType="Analyzer"
ReferenceOutputAssembly="false"/>
<ProjectReference Include="..\..\src\Sentry\Sentry.csproj" />
<Using Include="Android.App.Activity" Alias="Activity" />

Expand Down
3 changes: 0 additions & 3 deletions samples/Sentry.Samples.Ios/Sentry.Samples.Ios.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,6 @@
<ItemGroup>
<!-- <PackageReference Include="Sentry" Version="..." /> -->
<ProjectReference Include="..\..\src\Sentry\Sentry.csproj" />
<ProjectReference Include="..\..\src\Sentry.SourceGenerators\Sentry.SourceGenerators.csproj"
OutputItemType="Analyzer"
ReferenceOutputAssembly="false"/>
</ItemGroup>

</Project>
3 changes: 0 additions & 3 deletions samples/Sentry.Samples.MacCatalyst/Sentry.Samples.MacCatalyst.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,6 @@
<ItemGroup>
<!-- <PackageReference Include="Sentry" Version="..." /> -->
<ProjectReference Include="..\..\src\Sentry\Sentry.csproj" />
<ProjectReference Include="..\..\src\Sentry.SourceGenerators\Sentry.SourceGenerators.csproj"
OutputItemType="Analyzer"
ReferenceOutputAssembly="false"/>
</ItemGroup>

</Project>
2 changes: 1 addition & 1 deletion src/Sentry/CompilerServices/BuildProperties.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ public static class BuildProperties
/// <summary>
/// The Build Variables generated from you csproj file and initialized by the Sentry Source Generated Module Initializer
/// </summary>
public static IReadOnlyDictionary<string, string>? Values { get; private set; }
internal static IReadOnlyDictionary<string, string>? Values { get; set; }

/// <summary>
/// This is called by a Sentry Source-Generator module initializers to help us determine things like
Expand Down
Loading
Loading