Skip to content

Conversation

@jpnurmi
Copy link
Collaborator

@jpnurmi jpnurmi commented Jul 25, 2025

Replaced duplicate Sentry-CI-Build-Linux-arm64.slnf and Sentry-CI-Build-Linux-musl.slnf solution filters with Sentry-CI-Build-Linux-NoMobile.slnf and made it inherit .generated.NoMobile.sln.

Before:

  • Sentry-CI-Build-Linux.slnf
  • Sentry-CI-Build-Linux-arm64.slnf
  • Sentry-CI-Build-Linux-musl.slnf

After:

  • Sentry-CI-Build-Linux.slnf
  • Sentry-CI-Build-Linux-NoMobile.slnf

As discussed in:

#skip-changelog

@jpnurmi jpnurmi marked this pull request as ready for review July 27, 2025 20:05
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Mobile Projects Included in Linux Build

The patterns section for the new Sentry-CI-Build-Linux-NoMobile.slnf configuration is empty. This omission means mobile-related projects (e.g., **/*Android*.csproj, **/*DeviceTests*.csproj, **/*Maui*.csproj), which were previously excluded, will now be included. This will cause compilation failures on Linux builds, as these platforms do not support mobile targets.

scripts/generate-solution-filters-config.yaml#L63-L64

- "trimTests"
patterns:

Fix in CursorFix in Web


@Flash0ver
Copy link
Member

Bug: Mobile Projects Included in Linux Build

The patterns section for the new Sentry-CI-Build-Linux-NoMobile.slnf configuration is empty. This omission means mobile-related projects (e.g., **/*Android*.csproj, **/*DeviceTests*.csproj, **/*Maui*.csproj), which were previously excluded, will now be included. This will cause compilation failures on Linux builds, as these platforms do not support mobile targets.

scripts/generate-solution-filters-config.yaml#L63-L64

...

@cursor Not sure if I get that comment right.
The patterns section of the new Sentry-CI-Build-Linux-NoMobile.slnf is actually not empty.

This changeset is essentially merging the duplicate Sentry-CI-Build-Linux-musl.slnf and Sentry-CI-Build-Linux-arm64.slnf into a single Sentry-CI-Build-Linux-NoMobile.slnf, and updating all usages.

@jpnurmi jpnurmi merged commit c65ee0a into main Jul 28, 2025
34 of 35 checks passed
@jpnurmi jpnurmi deleted the build/linux-nomobile branch July 28, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants