Skip to content

fix: Sentry Cocoa framework version #4411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpnurmi merged 10 commits into from
Aug 12, 2025
Merged

fix: Sentry Cocoa framework version #4411

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3e1beec
fix: version Sentry-Dynamic.xcframework
jpnurmi Aug 5, 2025
17aa445
Update CHANGELOG.md
jpnurmi Aug 5, 2025
5fb1633
Setup exactly once
jpnurmi Aug 5, 2025
10eec20
release: 5.14.0-alpha.0
getsentry-bot Aug 5, 2025
e5e9cc0
Merge branch 'release/5.14.0-alpha.0' into fix/sentry-cocoa-version
Aug 5, 2025
c25952a
Restore condition for inner _SetupCocoaSDK
jpnurmi Aug 6, 2025
c25ceec
Apply suggestions from code review
jpnurmi Aug 7, 2025
ae08265
Merge branch 'main' into fix/sentry-cocoa-version
jamescrosswell Aug 10, 2025
6dc3dd2
Merge remote-tracking branch 'upstream/main' into fix/sentry-cocoa-ve…
jpnurmi Aug 11, 2025
55b11b1
Fix CHANGELOG.md
jpnurmi Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Setup exactly once
  • Loading branch information
@jpnurmi
jpnurmi committed Aug 5, 2025
commit 5fb163398335ca16a38120e4ef77ef0b7a4dff6b
18 changes: 14 additions & 4 deletions src/Sentry.Bindings.Cocoa/Sentry.Bindings.Cocoa.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<IsBindingProject>true</IsBindingProject>
<MtouchNoSymbolStrip>true</MtouchNoSymbolStrip>
<Description>.NET Bindings for the Sentry Cocoa SDK</Description>
<SentryCocoaCache>$(MSBuildThisFileDirectory)..\..\modules\sentry-cocoa\</SentryCocoaCache>
<SentryCocoaCache>..\..\modules\sentry-cocoa\</SentryCocoaCache>
<SentryCocoaFrameworkHeaders>$(SentryCocoaCache)Sentry.framework\</SentryCocoaFrameworkHeaders>
<SentryCocoaProperties>$([System.IO.File]::ReadAllText("$(MSBuildThisFileDirectory)../../modules/sentry-cocoa.properties"))</SentryCocoaProperties>
<SentryCocoaVersion>$([System.Text.RegularExpressions.Regex]::Match($(SentryCocoaProperties), 'version\s*=\s*([^\s]+)').Groups[1].Value)</SentryCocoaVersion>
Expand Down Expand Up @@ -48,9 +48,7 @@
</ItemGroup>

<!-- Downloads and sets up the Cocoa SDK: dotnet msbuild /t:setupCocoaSDK src/Sentry.Bindings.Cocoa/Sentry.Bindings.Cocoa.csproj -->
<Target Name="SetupCocoaSDK"
Condition="$([MSBuild]::IsOSPlatform('OSX')) And !Exists('$(SentryCocoaFramework)')"
BeforeTargets="BeforeBuild">
<Target Name="_SetupCocoaSDK">

<Message Importance="High" Text="Setting up the Cocoa SDK version '$(SentryCocoaVersion)'." />

Expand Down Expand Up @@ -81,6 +79,18 @@
SkipUnchangedFiles="true" />
</Target>

<!-- Setup exactly once: https://learn.microsoft.com/en-gb/visualstudio/msbuild/run-target-exactly-once -->
<Target Name="SetupCocoaSDKBeforeOuterBuild" DependsOnTargets="_SetupCocoaSDK"
Condition="$([MSBuild]::IsOSPlatform('OSX')) And !Exists('$(SentryCocoaFramework)')"
BeforeTargets="DispatchToInnerBuilds" />

<Target Name="SetupCocoaSDK"
BeforeTargets="BeforeBuild"
Condition="$([MSBuild]::IsOSPlatform('OSX')) And !Exists('$(SentryCocoaFramework)')">
<!-- Setup exactly once: https://learn.microsoft.com/en-gb/visualstudio/msbuild/run-target-exactly-once -->
<MSBuild Projects="$(MSBuildProjectFullPath)" Targets="_SetupCocoaSDK" RemoveProperties="TargetFramework" />
</Target>

<Target Name="CleanCocoaSDK" AfterTargets="Clean" Condition="$([MSBuild]::IsOSPlatform('OSX'))">
<RemoveDir Directories="$(SentryCocoaCache)" ContinueOnError="true" />
</Target>
Expand Down
Loading