Skip to content

feat: Add support for w3c trace parent headers for outgoing requests #4661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markushi merged 5 commits into from
Oct 22, 2025
Merged

feat: Add support for w3c trace parent headers for outgoing requests #4661

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aaaf007
feat: Add support for w3c trace parent headers for outgoing requests
markushi Oct 21, 2025
0a0945a
Add changelog
markushi Oct 21, 2025
ad20f7e
Verify & bindable options
bitsandfoxes Oct 21, 2025
ff02acb
Add more tests
markushi Oct 22, 2025
1d25c56
Update src/Sentry/SentryOptions.cs
markushi Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add more tests
  • Loading branch information
@markushi
markushi committed Oct 22, 2025
commit ff02acbdf066dbb5ba9d239b4577ca35dd9de2d7
79 changes: 79 additions & 0 deletions test/Sentry.Tests/SentryHttpMessageHandlerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,85 @@ public async Task SendAsync_SentryTraceHeaderAlreadySet_NotOverwritten()
string.Concat(h.Value) == "foobar");
}

[Fact]
public async Task SendAsync_W3C_TraceParent_NotSet_WhenPropagateTraceparentIsFalse()
{
// Arrange
var hub = Substitute.For<IHub>();

hub.GetTraceHeader().ReturnsForAnyArgs(
SentryTraceHeader.Parse("75302ac48a024bde9a3b3734a82e36c8-1000000000000000-0"));

var failedRequestHandler = Substitute.For<ISentryFailedRequestHandler>();
var options = new SentryOptions();
using var innerHandler = new RecordingHttpMessageHandler(new FakeHttpMessageHandler());
using var sentryHandler = new SentryHttpMessageHandler(hub, options, innerHandler, failedRequestHandler);
using var client = new HttpClient(sentryHandler);

// Act
await client.GetAsync("https://localhost/");

using var request = innerHandler.GetRequests().Single();

// Assert
request.Headers.Should().NotContain(h => h.Key == "traceparent");
}

[Fact]
public async Task SendAsync_W3C_TraceParent_Set_WhenPropagateTraceparentIsTrue()
{
// Arrange
var hub = Substitute.For<IHub>();

hub.GetTraceHeader().ReturnsForAnyArgs(
SentryTraceHeader.Parse("75302ac48a024bde9a3b3734a82e36c8-1000000000000000-0"));

var failedRequestHandler = Substitute.For<ISentryFailedRequestHandler>();
var options = new SentryOptions();
options.PropagateTraceparent = true;
using var innerHandler = new RecordingHttpMessageHandler(new FakeHttpMessageHandler());
using var sentryHandler = new SentryHttpMessageHandler(hub, options, innerHandler, failedRequestHandler);
using var client = new HttpClient(sentryHandler);

client.DefaultRequestHeaders.Add("sentry-trace", "foobar");

// Act
await client.GetAsync("https://localhost/");

using var request = innerHandler.GetRequests().Single();

// Assert
request.Headers.Should().Contain(h => h.Key == "traceparent" && h.Value.Single() == "00-75302ac48a024bde9a3b3734a82e36c8-1000000000000000-00");
}

[Fact]
public async Task SendAsync_W3C_TraceParent_NotSet_WhenPropagateTraceparentAlreadySet()
{
// Arrange
var hub = Substitute.For<IHub>();

hub.GetTraceHeader().ReturnsForAnyArgs(
SentryTraceHeader.Parse("75302ac48a024bde9a3b3734a82e36c8-1000000000000000-0"));

var failedRequestHandler = Substitute.For<ISentryFailedRequestHandler>();
var options = new SentryOptions();
options.PropagateTraceparent = true;
using var innerHandler = new RecordingHttpMessageHandler(new FakeHttpMessageHandler());
using var sentryHandler = new SentryHttpMessageHandler(hub, options, innerHandler, failedRequestHandler);
using var client = new HttpClient(sentryHandler);

client.DefaultRequestHeaders.Add("sentry-trace", "foobar");
client.DefaultRequestHeaders.Add("traceparent", "existing-value");

// Act
await client.GetAsync("https://localhost/");

using var request = innerHandler.GetRequests().Single();

// Assert
request.Headers.Should().Contain(h => h.Key == "traceparent" && h.Value.Single() == "existing-value");
}

[Fact]
public async Task SendAsync_TransactionOnScope_StartsNewSpan()
{
Expand Down
Loading