Skip to content

feat: disable Telemetry Buffer by default #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
giortzisg merged 2 commits into from
Nov 27, 2025
Merged

feat: disable Telemetry Buffer by default #1149

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12b25b1
fix: noop Telemetry Buffers
giortzisg Nov 27, 2025
b3ba3a9
fix: lint
giortzisg Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: lint
  • Loading branch information
@giortzisg
giortzisg committed Nov 27, 2025
commit b3ba3a95e4e57a04a348f8f485566b0f8a1cd5fd
8 changes: 4 additions & 4 deletions client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,9 +381,9 @@ func NewClient(options ClientOptions) (*Client, error) {
client.setupTransport()

// noop Telemetry Buffers fow now
//if !options.DisableTelemetryBuffer {
// client.setupTelemetryBuffer()
//} else
// if !options.DisableTelemetryBuffer {
// client.setupTelemetryBuffer()
// } else
if options.EnableLogs {
client.batchLogger = NewBatchLogger(&client)
client.batchLogger.Start()
Expand All @@ -410,7 +410,7 @@ func (client *Client) setupTransport() {
client.Transport = transport
}

func (client *Client) setupTelemetryBuffer() {
func (client *Client) setupTelemetryBuffer() { // nolint: unused
if client.options.DisableTelemetryBuffer {
return
}
Expand Down
2 changes: 1 addition & 1 deletion client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1036,7 +1036,7 @@ func TestClientSetsUpTransport(t *testing.T) {
require.IsType(t, &noopTransport{}, client.Transport)
}

//func TestClient_SetupTelemetryBuffer_WithDSN(t *testing.T) {
// func TestClient_SetupTelemetryBuffer_WithDSN(t *testing.T) {
// client, err := NewClient(ClientOptions{
// Dsn: "https://public@localhost/1",
// })
Expand Down
Loading