fix: use neutral Locale for String operations#1033
Merged
marandaneto merged 2 commits intomainfrom Nov 12, 2020
Merged
Conversation
marandaneto
requested review from
bruno-garcia and
maciejwalkowiak
as code owners
maciejwalkowiak
approved these changes
Nov 10, 2020
Contributor
maciejwalkowiak
left a comment
maciejwalkowiak
left a comment
There was a problem hiding this comment.
Should there be an entry in the changelog?
Contributor
Author
yep, forgot about it, will do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
fix: use neutral Locale for String operations
💡 Motivation and Context
All the other String operations already a neutral Locale
💚 How did you test it?
📝 Checklist
🔮 Next steps