Fix: Graceful Shutdown flushes event instead of Closing SDK#1500
Merged
marandaneto merged 5 commits intomainfrom May 31, 2021
Merged
Fix: Graceful Shutdown flushes event instead of Closing SDK#1500marandaneto merged 5 commits intomainfrom
marandaneto merged 5 commits intomainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1500 +/- ##
============================================
+ Coverage 76.00% 76.03% +0.02%
- Complexity 1926 1929 +3
============================================
Files 191 191
Lines 6665 6673 +8
Branches 663 664 +1
============================================
+ Hits 5066 5074 +8
Misses 1274 1274
Partials 325 325
Continue to review full report at Codecov.
|
bruno-garcia
approved these changes
May 31, 2021
Member
bruno-garcia
left a comment
There was a problem hiding this comment.
@Tyrrrz we need the same thing in .NET. Basically Dispose should only flush, particularly from Unity and ASP.NET Core and other integrations application shutdown hook where we don't guarantee we're the last thing to shut down.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Fix: Graceful Shutdown flushes event instead of Closing SDK
💡 Motivation and Context
Fix #1458
💚 How did you test it?
📝 Checklist
🔮 Next steps