Conversation
Codecov Report
@@ Coverage Diff @@
## main #1609 +/- ##
============================================
- Coverage 75.93% 75.93% -0.01%
- Complexity 2003 2004 +1
============================================
Files 202 202
Lines 6939 6943 +4
Branches 690 691 +1
============================================
+ Hits 5269 5272 +3
- Misses 1334 1335 +1
Partials 336 336
Continue to review full report at Codecov.
|
philipphofmann
left a comment
There was a problem hiding this comment.
Looks already good. I added a few comments.
sentry-android-core/src/main/java/io/sentry/android/core/ActivityFramesState.java
Outdated
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/ActivityFramesState.java
Outdated
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/ActivityFramesState.java
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/ActivityLifecycleIntegration.java
Outdated
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/ActivityLifecycleIntegration.java
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/AppStartState.java
Show resolved
Hide resolved
philipphofmann
left a comment
There was a problem hiding this comment.
Just one open comment about the naming. Is it hard to add tests for ActivityFramesTracker or how is it tested?
bruno-garcia
left a comment
There was a problem hiding this comment.
Just a couple notes (given it's a draft)
sentry-android-core/src/main/java/io/sentry/android/core/ActivityLifecycleIntegration.java
Outdated
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/PerformanceAndroidEventProcessor.java
Outdated
Show resolved
Hide resolved
philipphofmann
left a comment
There was a problem hiding this comment.
One tiny comment, and is it possible to add tests for ActivityFramesTracker?
sentry/src/main/java/io/sentry/TransactionFinishedCallback.java
Outdated
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/AppStartState.java
Outdated
Show resolved
Hide resolved
bruno-garcia
left a comment
There was a problem hiding this comment.
Other than some small suggestions LGTM! 🚀
sentry-android-core/src/main/java/io/sentry/android/core/ActivityFramesTracker.java
Outdated
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/ActivityLifecycleIntegration.java
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/ActivityLifecycleIntegration.java
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/PerformanceAndroidEventProcessor.java
Show resolved
Hide resolved
...ry-android-core/src/test/java/io/sentry/android/core/PerformanceAndroidEventProcessorTest.kt
Show resolved
Hide resolved
applied them and added one more test too, thanks |
📜 Description
Feat: Slow/Frozen frames metrics
💡 Motivation and Context
Closes #1466
💚 How did you test it?
📝 Checklist
🔮 Next steps