Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1656 +/- ##
============================================
- Coverage 75.74% 75.74% -0.01%
+ Complexity 2017 2016 -1
============================================
Files 206 206
Lines 7038 7037 -1
Branches 699 699
============================================
- Hits 5331 5330 -1
Misses 1369 1369
Partials 338 338
Continue to review full report at Codecov.
|
marandaneto
reviewed
Aug 18, 2021
marandaneto
approved these changes
Aug 18, 2021
Contributor
marandaneto
left a comment
There was a problem hiding this comment.
left a suggestion but LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Merge external map properties
💡 Motivation and Context
Fixes #874
Now tags can be set in multiple places: some in properties file, some in env variables. The resulting options will contain tags from all places.
💚 How did you test it?
Unit tests
📝 Checklist
Not breaking in terms of compilation, but resulting tags can differ if they were set in different places (unlikely though).
🔮 Next steps
The order of loading properties can (and probably should) be changed. Providers order by priority I think should be: