Refactor OkHttp and Apollo to Kotlin functional interfaces.#1797
Merged
marandaneto merged 4 commits intomainfrom Nov 12, 2021
Merged
Refactor OkHttp and Apollo to Kotlin functional interfaces.#1797marandaneto merged 4 commits intomainfrom
marandaneto merged 4 commits intomainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1797 +/- ##
=========================================
Coverage 75.74% 75.74%
Complexity 2194 2194
=========================================
Files 218 218
Lines 7804 7804
Branches 828 828
=========================================
Hits 5911 5911
Misses 1491 1491
Partials 402 402
Continue to review full report at Codecov.
|
Contributor
|
That sounds like a nice refactoring, is it a breaking change in Java or Kotlin? or IDE would just point out to simplify the code? |
marandaneto
reviewed
Nov 8, 2021
Contributor
marandaneto
left a comment
There was a problem hiding this comment.
there's a comment to be answered otherwise LGTM, thanks!
marandaneto
approved these changes
Nov 9, 2021
romtsn
approved these changes
Nov 9, 2021
Contributor
Author
|
Tested - non breaking for both Java and Kotlin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Refactor OkHttp and Apollo to Kotlin functional interfaces.
💡 Motivation and Context
Reduces boilerplate when using callbacks in Kotlin code.
💚 How did you test it?
Already covered with unit tests.
📝 Checklist