Feat: Add secondary constructor to SentryInstrumentation.#1804
Merged
marandaneto merged 2 commits intomainfrom Nov 12, 2021
Merged
Feat: Add secondary constructor to SentryInstrumentation.#1804marandaneto merged 2 commits intomainfrom
SentryInstrumentation.#1804marandaneto merged 2 commits intomainfrom
Conversation
romtsn
approved these changes
Nov 12, 2021
Codecov Report
@@ Coverage Diff @@
## main #1804 +/- ##
============================================
- Coverage 75.74% 75.72% -0.02%
Complexity 2194 2194
============================================
Files 218 218
Lines 7804 7806 +2
Branches 828 828
============================================
Hits 5911 5911
- Misses 1491 1493 +2
Partials 402 402
Continue to review full report at Codecov.
|
marandaneto
approved these changes
Nov 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Feat: Add secondary constructor to
SentryInstrumentation.💡 Motivation and Context
It wasn't possible to pass
BeforeSpanCallbackwithout passing theHub.💚 How did you test it?
📝 Checklist
🔮 Next steps