Merged
Conversation
marandaneto
reviewed
Feb 12, 2022
marandaneto
reviewed
Feb 12, 2022
marandaneto
reviewed
Feb 12, 2022
sentry-spring/src/main/java/io/sentry/spring/SentryInitBeanPostProcessor.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #1909 +/- ##
============================================
+ Coverage 75.42% 75.46% +0.03%
- Complexity 2244 2248 +4
============================================
Files 225 225
Lines 8026 8037 +11
Branches 852 852
============================================
+ Hits 6054 6065 +11
Misses 1562 1562
Partials 410 410
Continue to review full report at Codecov.
|
marandaneto
approved these changes
Feb 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Fix potential memory leaks - happening either when Sentry works in servlet environment on application undeployment - or when more than one integration is active.
💚 How did you test it?
Running a sample application. I am not sure if there is a way to write a test for that.
📝 Checklist