Add Timber and Fragment integrations if they are present on the classpath#1936
Merged
Add Timber and Fragment integrations if they are present on the classpath#1936
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1936 +/- ##
=========================================
Coverage 75.60% 75.60%
Complexity 2270 2270
=========================================
Files 225 225
Lines 8072 8072
Branches 852 852
=========================================
Hits 6103 6103
Misses 1558 1558
Partials 411 411 Continue to review full report at Codecov.
|
Contributor
static final String SENTRY_FRAGMENT_INTEGRATION_CLASS_NAME =
"io.sentry.android.fragment.FragmentLifecycleIntegration";
static final String SENTRY_TIMBER_INTEGRATION_CLASS_NAME =
"io.sentry.android.timber.SentryTimberIntegration";Are these class names excluded from R8 obfuscation? Otherwise these might not be found in Android Release builds at runtime. |
marandaneto
reviewed
Mar 7, 2022
sentry-android-core/src/main/java/io/sentry/android/core/AndroidOptionsInitializer.java
Outdated
Show resolved
Hide resolved
marandaneto
reviewed
Mar 7, 2022
sentry-android-core/src/test/java/io/sentry/android/core/AndroidOptionsInitializerTest.kt
Outdated
Show resolved
Hide resolved
marandaneto
reviewed
Mar 7, 2022
sentry-android-core/src/main/java/io/sentry/android/core/AndroidOptionsInitializer.java
Outdated
Show resolved
Hide resolved
marandaneto
reviewed
Mar 7, 2022
sentry-android-core/src/main/java/io/sentry/android/core/AndroidOptionsInitializer.java
Show resolved
Hide resolved
marandaneto
reviewed
Mar 7, 2022
...ry-android-fragment/src/main/java/io/sentry/android/fragment/FragmentLifecycleIntegration.kt
Outdated
Show resolved
Hide resolved
marandaneto
reviewed
Mar 7, 2022
...ry-samples/sentry-samples-android/src/main/java/io/sentry/samples/android/MyApplication.java
Outdated
Show resolved
Hide resolved
bruno-garcia
reviewed
Mar 8, 2022
sentry-android-core/src/main/java/io/sentry/android/core/AndroidOptionsInitializer.java
Outdated
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/AndroidOptionsInitializer.java
Show resolved
Hide resolved
...ry-android-fragment/src/main/java/io/sentry/android/fragment/FragmentLifecycleIntegration.kt
Outdated
Show resolved
Hide resolved
marandaneto
reviewed
Mar 9, 2022
Member
Author
|
@marandaneto addressed everything, PTAL once again |
Member
Author
@audkar thanks for raising the concern. Yes, we ship those modules with proguard rules that keep those classes, see here and here |
marandaneto
reviewed
Mar 11, 2022
sentry-android-core/src/main/java/io/sentry/android/core/ActivityFramesTracker.java
Outdated
Show resolved
Hide resolved
marandaneto
reviewed
Mar 11, 2022
sentry-android-core/src/main/java/io/sentry/android/core/SentryAndroid.java
Show resolved
Hide resolved
marandaneto
reviewed
Mar 11, 2022
sentry-android-core/src/main/java/io/sentry/android/core/SentryAndroid.java
Outdated
Show resolved
Hide resolved
marandaneto
reviewed
Mar 11, 2022
sentry-android-core/src/test/java/io/sentry/android/core/AndroidOptionsInitializerTest.kt
Show resolved
Hide resolved
marandaneto
reviewed
Mar 11, 2022
sentry-android-core/src/test/java/io/sentry/android/core/SentryAndroidTest.kt
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/LoadClass.java
Outdated
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/SentryAndroid.java
Show resolved
Hide resolved
...ry-samples/sentry-samples-android/src/main/java/io/sentry/samples/android/MyApplication.java
Show resolved
Hide resolved
…lass.java Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
marandaneto
approved these changes
Mar 15, 2022
bruno-garcia
approved these changes
Mar 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
sentry-android-timberandsentry-android-fragmentare on the classpath and adds the integrations automatically.💡 Motivation and Context
Q1 goal
💚 How did you test it?
📝 Checklist
🔮 Next steps