make profiling rate defaults to 101 hz#2211
Merged
stefanosiano merged 7 commits intomainfrom Aug 8, 2022
Merged
Conversation
added internal profilingTracesHz option default profilingTracesHz is now 101, to avoid lockstep sampling
added internal profilingTracesHz option default profilingTracesHz is now 101, to avoid lockstep sampling
added internal profilingTracesHz option default profilingTracesHz is now 101, to avoid lockstep sampling
Codecov Report
@@ Coverage Diff @@
## main #2211 +/- ##
=========================================
Coverage 80.65% 80.65%
Complexity 3355 3355
=========================================
Files 240 240
Lines 12324 12324
Branches 1633 1633
=========================================
Hits 9940 9940
Misses 1778 1778
Partials 606 606 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
adinauer
approved these changes
Aug 5, 2022
|
|
||
| ## Unreleased | ||
|
|
||
| ### Fixes |
Member
There was a problem hiding this comment.
Ah didn't notice the changelog was wrong on main
Contributor
Author
There was a problem hiding this comment.
yeah, probably could even be when i merged another pr 😅. Not sure, though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
profilingTracesIntervalMillisoptionprofilingTracesHzoptionprofilingTracesHzis now 101, to avoid lockstep sampling💡 Motivation and Context
profilingTracesIntervalMillisshould not be exposed to the user, at least for nowprofilingTracesHzoption💚 How did you test it?
Unit test to check
profilingTracesIntervalMillisis ignored andprofilingTracesHzis used, instead.📝 Checklist
🔮 Next steps