Use toString for enum serialization

[adinauer]

📜 Description

Use toString() for enum entries being serialized.

💡 Motivation and Context

JsonReflectionObjectSerializer would consume lots of memory when serializing an enum entry where the enum has more than just a few entries.

Fixes #2219

💚 How did you test it?

Unit Test

📝 Checklist

• I reviewed the submitted code
• I added tests to verify the changes
• I updated the docs if needed
• No breaking changes

🔮 Next steps

[codecov-commenter]

Codecov Report

Merging #2220 (a869430) into main (bf18c0d) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2220      +/-   ##
============================================
+ Coverage     80.61%   80.64%   +0.02%     
- Complexity     3355     3357       +2     
============================================
  Files           240      240              
  Lines         12327    12331       +4     
  Branches       1634     1636       +2     
============================================
+ Hits           9938     9944       +6     
+ Misses         1782     1781       -1     
+ Partials        607      606       -1     

Impacted Files	Coverage Δ
.../src/main/java/io/sentry/JsonObjectSerializer.java	83.33% <100.00%> (+0.57%)	⬆️
...java/io/sentry/JsonReflectionObjectSerializer.java	91.04% <100.00%> (+0.27%)	⬆️
...n/java/io/sentry/transport/ReusableCountLatch.java	88.23% <0.00%> (+5.88%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[rsolci]

Hey @adinauer, really thanks for the quick response. But I am thinking if this solution wouldn't be better in the JsonObjectSerializer class since there is already a conditional checking the type of the object to serialize and only calls the reflection one as a fallback for unknown types.

[adinauer]

better in the JsonObjectSerializer class since there is already a conditional checking the type of the object to serialize and only calls the reflection one as a fallback for unknown types.

As an optimmization it could be added to both. But it should be in JsonReflectionObjectSerializer to also cover fields of complex objects being serialized.

[marandaneto]

WHat's about object..name()? Does it return the same thing?

[adinauer]

We'd have to use reflection to invoke .name(). By default .toString() should be the same as .name(). It also allows overriding the value that is serialized.