Concurrent profiling 3 - truncation reason#2247
Merged
stefanosiano merged 6 commits intofeat/concurrent-profiling-datafrom Sep 19, 2022
Merged
Concurrent profiling 3 - truncation reason#2247stefanosiano merged 6 commits intofeat/concurrent-profiling-datafrom
stefanosiano merged 6 commits intofeat/concurrent-profiling-datafrom
Conversation
added uitest to check default profile truncation reason is "normal"
added unit test for truncation reason and updated another to remove a testOnly useless method
…ng-truncation-reason
added unit test for truncation reason and updated another to remove a testOnly useless method
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## feat/concurrent-profiling-data #2247 +/- ##
=================================================================
Coverage ? 80.27%
Complexity ? 3367
=================================================================
Files ? 241
Lines ? 12447
Branches ? 1661
=================================================================
Hits ? 9992
Misses ? 1828
Partials ? 627 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
added unit test for truncation reason and updated another to remove a testOnly useless method
stefanosiano
changed the title
added unit test for truncation reason and updated another to remove a testOnly useless method
adinauer
approved these changes
Sep 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
We are adding the truncation reason in case a profile is truncated.
If no truncation occurs, we will send
normal, while if a timeout occurs, we will sendtimeoutastruncation_reasonin the envelope payload.💡 Motivation and Context
The backend was unable to understand if a profile was terminated on purpose or due to an error.
💚 How did you test it?
Added a ui and unit test
📝 Checklist
🔮 Next steps