Set transactionNameSource to CUSTOM when setting transaction name#2405
Merged
Set transactionNameSource to CUSTOM when setting transaction name#2405
Conversation
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f809aac | 301.51 ms | 346.60 ms | 45.09 ms |
| 81a1a6c | 328.73 ms | 421.28 ms | 92.55 ms |
| 4a9c176 | 319.77 ms | 363.20 ms | 43.43 ms |
| 3695453 | 299.25 ms | 360.04 ms | 60.79 ms |
| 7967d22 | 289.28 ms | 377.11 ms | 87.83 ms |
| 507f924 | 342.51 ms | 402.65 ms | 60.14 ms |
| 4a9c176 | 336.33 ms | 384.73 ms | 48.41 ms |
| 3695453 | 314.63 ms | 353.10 ms | 38.47 ms |
| 38e4f11 | 358.20 ms | 433.73 ms | 75.53 ms |
| 16371c5 | 314.02 ms | 394.54 ms | 80.52 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f809aac | 1.73 MiB | 2.32 MiB | 608.63 KiB |
| 81a1a6c | 1.73 MiB | 2.32 MiB | 612.47 KiB |
| 4a9c176 | 1.73 MiB | 2.33 MiB | 612.69 KiB |
| 3695453 | 1.73 MiB | 2.32 MiB | 611.62 KiB |
| 7967d22 | 1.73 MiB | 2.32 MiB | 612.47 KiB |
| 507f924 | 1.73 MiB | 2.32 MiB | 609.95 KiB |
| 4a9c176 | 1.73 MiB | 2.33 MiB | 612.69 KiB |
| 3695453 | 1.73 MiB | 2.32 MiB | 611.62 KiB |
| 38e4f11 | 1.73 MiB | 2.32 MiB | 609.82 KiB |
| 16371c5 | 1.73 MiB | 2.32 MiB | 611.62 KiB |
marandaneto
reviewed
Dec 1, 2022
| } | ||
|
|
||
| this.name = name; | ||
| setName(name, TransactionNameSource.CUSTOM); |
Contributor
There was a problem hiding this comment.
Do we call this method internally?
If we do, we cannot overwrite to custom, only if the user does.
Member
Author
There was a problem hiding this comment.
Good point will check. But if so we could simply change our code to use the other overload.
Member
Author
There was a problem hiding this comment.
Couldn't find any direct calls to this overload (outside of tests).
Member
Author
There was a problem hiding this comment.
Should we check cross platform SDKs before merging this?
Member
Author
There was a problem hiding this comment.
@marandaneto should we check any SDKs first or can I go ahead and merge this PR?
romtsn
approved these changes
Dec 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Set source to CUSTOM when setting transaction name without source
💡 Motivation and Context
Transaction name could be set by user and previously set source would be kept.
💚 How did you test it?
Unit Test
📝 Checklist
🔮 Next steps