Conversation
Contributor
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4b32504 | 315.69 ms | 373.96 ms | 58.27 ms |
| 754021c | 358.70 ms | 361.98 ms | 3.28 ms |
| c1399c1 | 345.06 ms | 385.49 ms | 40.43 ms |
| 5fa24ec | 326.29 ms | 384.53 ms | 58.24 ms |
| fe30606 | 310.82 ms | 335.36 ms | 24.55 ms |
| f6a135d | 263.96 ms | 383.59 ms | 119.63 ms |
| 14c083a | 350.82 ms | 388.86 ms | 38.04 ms |
| 4b32504 | 357.14 ms | 404.04 ms | 46.90 ms |
| fe30606 | 327.46 ms | 351.74 ms | 24.28 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4b32504 | 1.73 MiB | 2.34 MiB | 623.74 KiB |
| 754021c | 1.73 MiB | 2.33 MiB | 623.06 KiB |
| c1399c1 | 1.73 MiB | 2.33 MiB | 620.61 KiB |
| 5fa24ec | 1.73 MiB | 2.33 MiB | 620.61 KiB |
| fe30606 | 1.73 MiB | 2.34 MiB | 623.74 KiB |
| f6a135d | 1.73 MiB | 2.33 MiB | 623.10 KiB |
| 14c083a | 1.73 MiB | 2.33 MiB | 620.61 KiB |
| 4b32504 | 1.73 MiB | 2.34 MiB | 623.74 KiB |
| fe30606 | 1.73 MiB | 2.34 MiB | 623.74 KiB |
Previous results on branch: feat/add-enable-tracing
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d6b4286 | 340.94 ms | 385.46 ms | 44.52 ms |
| 9a2b68e | 387.20 ms | 444.36 ms | 57.16 ms |
| 72b2528 | 302.10 ms | 378.77 ms | 76.67 ms |
| f7a4308 | 303.88 ms | 325.63 ms | 21.75 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d6b4286 | 1.73 MiB | 2.34 MiB | 623.95 KiB |
| 9a2b68e | 1.73 MiB | 2.34 MiB | 623.95 KiB |
| 72b2528 | 1.73 MiB | 2.34 MiB | 624.39 KiB |
| f7a4308 | 1.73 MiB | 2.34 MiB | 623.96 KiB |
Codecov ReportBase: 80.20% // Head: 80.21% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2530 +/- ##
============================================
+ Coverage 80.20% 80.21% +0.01%
- Complexity 3960 3970 +10
============================================
Files 324 324
Lines 14937 14952 +15
Branches 1968 1972 +4
============================================
+ Hits 11980 11994 +14
Misses 2183 2183
- Partials 774 775 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Member
Author
|
Here's the test for PHP documenting how the options combine: https://github.com/getsentry/sentry-php/pull/1458/files#diff-fa1abff32fd8afc425213dea903ea43386633e2123cc0611c7c2582811d8cffeR631-R653 |
adinauer
commented
Feb 10, 2023
sentry-android-core/src/main/java/io/sentry/android/core/ManifestMetadataReader.java
Show resolved
Hide resolved
adinauer
commented
Feb 10, 2023
romtsn
reviewed
Feb 14, 2023
romtsn
reviewed
Feb 14, 2023
sentry-samples/sentry-samples-android/src/main/AndroidManifest.xml
Outdated
Show resolved
Hide resolved
romtsn
reviewed
Feb 14, 2023
romtsn
approved these changes
Feb 14, 2023
Member
romtsn
left a comment
There was a problem hiding this comment.
a couple of small things, but LGTM otherwise, thanks 🚀
….xml Co-authored-by: Roman Zavarnitsyn <rom4ek93@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Adds a new
enableTracingoption. If set to true, performance is enabled, even if notracesSampleRateortracesSamplerhave been configured. For now we set a defaulttracesSampleRateof1.0if none has been configured explicitly. IfenableTracingis set tofalseperformance is disabled, regardless oftracesSampleRateandtracesSampleroptions. The default forenableTracingisnullmeaning existing behaviour remains unchanged (setting eithertracesSampleRateortracesSamplerenables performance)💡 Motivation and Context
Closes #2522
💚 How did you test it?
Unit tests, manually using Android and Spring Boot (Jakarta)
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps