Conversation
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d81684e | 235.73 ms | 328.76 ms | 93.03 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d81684e | 1.73 MiB | 2.26 MiB | 547.78 KiB |
Previous results on branch: feat/user-name-and-geo
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 96e2af6 | 412.22 ms | 432.49 ms | 20.26 ms |
| 87bd976 | 341.90 ms | 446.66 ms | 104.76 ms |
| 061e3dd | 329.84 ms | 393.36 ms | 63.52 ms |
| 2686d20 | 362.39 ms | 393.20 ms | 30.81 ms |
| 8b36629 | 344.80 ms | 381.90 ms | 37.10 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 96e2af6 | 1.73 MiB | 2.34 MiB | 626.19 KiB |
| 87bd976 | 1.73 MiB | 2.34 MiB | 626.56 KiB |
| 061e3dd | 1.73 MiB | 2.34 MiB | 626.62 KiB |
| 2686d20 | 1.73 MiB | 2.34 MiB | 626.73 KiB |
| 8b36629 | 1.73 MiB | 2.34 MiB | 626.76 KiB |
|
@denrase, did you tag me for review for a specific reason? If not, Roman or Markus could also have a look at this PR. |
markushi
left a comment
There was a problem hiding this comment.
Looking great, thanks for contributing - please have a look at my comments 🚀
sentry/src/test/java/io/sentry/protocol/UserSerializationTest.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # CHANGELOG.md
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2556 +/- ##
=========================================
Coverage 81.32% 81.33%
- Complexity 4192 4208 +16
=========================================
Files 336 337 +1
Lines 15489 15561 +72
Branches 2021 2031 +10
=========================================
+ Hits 12597 12657 +60
- Misses 2099 2110 +11
- Partials 793 794 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
|
@romtsn A UI running on CI test seems to be flaky. AFAIK this should not be connected to this PR. Can we merge or is there something to do first? |
merge it! |
📜 Description
nameproperty toUserGeoclassgeoproperty toUser💡 Motivation and Context
Relates to getsentry/sentry-dart#1065
💚 How did you test it?
Added unit tests
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Implement on cocoa and use in hybrid SDKs