Merged
Conversation
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 16cd2b6 | 243.02 ms | 349.69 ms | 106.67 ms |
| 46b1782 | 387.72 ms | 458.74 ms | 71.02 ms |
| 1707044 | 338.80 ms | 384.79 ms | 46.00 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 16cd2b6 | 1.72 MiB | 2.28 MiB | 570.95 KiB |
| 46b1782 | 1.72 MiB | 2.28 MiB | 570.44 KiB |
| 1707044 | 1.72 MiB | 2.28 MiB | 570.44 KiB |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2761 +/- ##
=========================================
Coverage 81.09% 81.10%
- Complexity 4470 4472 +2
=========================================
Files 347 347
Lines 16475 16482 +7
Branches 2232 2233 +1
=========================================
+ Hits 13361 13367 +6
- Misses 2181 2182 +1
Partials 933 933
☔ View full report in Codecov by Sentry. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
This is necessary in addition to
SentryThread.held_locksto highlight the offending frame in the UI, so the lock has to be also on the per-frame level.Relay PR: getsentry/relay#2171
💡 Motivation and Context
Q2 Goal
💚 How did you test it?
Manually and automated
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps