Infer duration from last frame for the unsent segment

sentry-android-replay/src/main/java/io/sentry/android/replay/ReplayCache.kt

@@ -10,7 +10,6 @@ import io.sentry.SentryLevel.ERROR
 import io.sentry.SentryLevel.WARNING
 import io.sentry.SentryOptions
 import io.sentry.SentryReplayEvent.ReplayType
-import io.sentry.SentryReplayEvent.ReplayType.SESSION
 import io.sentry.android.replay.video.MuxerConfig
 import io.sentry.android.replay.video.SimpleVideoEncoder
 import io.sentry.protocol.SentryId
@@ -22,6 +21,7 @@ import java.io.StringReader
 import java.util.Date
 import java.util.LinkedList
 import java.util.concurrent.atomic.AtomicBoolean
+import kotlin.math.ceil
 
 /**
  * A basic in-memory and disk cache for Session Replay frames. Frames are stored in order under the
@@ -360,14 +360,29 @@ public class ReplayCache internal constructor(
                 false
             }
 
+            if (cache.frames.isEmpty()) {
+                options.logger.log(
+                    DEBUG,
+                    "No frames found for replay: %s, deleting the replay",
+                    replayId
+                )
+                FileUtils.deleteRecursively(replayCacheDir)
+                return null
+            }
+
             cache.frames.sortBy { it.timestamp }
 
-            val duration = if (replayType == SESSION) {
-                options.experimental.sessionReplay.sessionSegmentDuration
-            } else {
-                options.experimental.sessionReplay.errorReplayDuration
+            fun roundToNearestFrame(duration: Long, frameDuration: Int): Long {
+                val frames = duration.toDouble() / frameDuration.toDouble()
+                return ceil(frames).toLong() * frameDuration
             }
 
+            // we need to round to the nearest frame to include breadcrumbs/events happened after the frame was captured
+            val duration = roundToNearestFrame(
+                duration = (cache.frames.last().timestamp - segmentTimestamp.time),
+                frameDuration = 1000 / frameRate
+            ) - 1 // we need to subtract 1ms to avoid capturing the next frame which doesn't exist
+
             val events = lastSegment[SEGMENT_KEY_REPLAY_RECORDING]?.let {
                 val reader = StringReader(it)
                 val recording = options.serializer.deserialize(reader, ReplayRecording::class.java)

sentry-android-replay/src/test/java/io/sentry/android/replay/ReplayCacheTest.kt

@@ -393,6 +393,12 @@ class ReplayCacheTest {
             )
         }
 
+        val screenshot = File(replayCacheFolder, "1720693523997.jpg").also { it.createNewFile() }
+        screenshot.outputStream().use {
+            Bitmap.createBitmap(1, 1, ARGB_8888).compress(JPEG, 80, it)
+            it.flush()
+        }
+
         val lastSegment = ReplayCache.fromDisk(fixture.options, replayId)!!
 
         assertEquals(912, lastSegment.recorderConfig.recordingHeight)
@@ -402,7 +408,7 @@ class ReplayCacheTest {
         assertEquals(0, lastSegment.id)
         assertEquals("2024-07-11T10:25:21.454Z", DateUtils.getTimestamp(lastSegment.timestamp))
         assertEquals(ReplayType.SESSION, lastSegment.replayType)
-        assertEquals(fixture.options.experimental.sessionReplay.sessionSegmentDuration, lastSegment.duration)
+        assertEquals(2999, lastSegment.duration)
         assertTrue {
             val firstEvent = lastSegment.events.first() as RRWebInteractionEvent
             firstEvent.timestamp == 1720693523997 &&

sentry-android-replay/src/test/java/io/sentry/android/replay/capture/SessionCaptureStrategyTest.kt

@@ -23,6 +23,7 @@ import io.sentry.android.replay.ReplayCache.Companion.SEGMENT_KEY_REPLAY_RECORDI
 import io.sentry.android.replay.ReplayCache.Companion.SEGMENT_KEY_REPLAY_TYPE
 import io.sentry.android.replay.ReplayCache.Companion.SEGMENT_KEY_TIMESTAMP
 import io.sentry.android.replay.ReplayCache.Companion.SEGMENT_KEY_WIDTH
+import io.sentry.android.replay.ReplayFrame
 import io.sentry.android.replay.ScreenshotRecorderConfig
 import io.sentry.cache.PersistingScopeObserver
 import io.sentry.protocol.SentryId
@@ -78,6 +79,7 @@ class SessionCaptureStrategyTest {
         }
         var persistedSegment = mutableMapOf<String, String?>()
         val replayCache = mock<ReplayCache> {
+            on { frames }.thenReturn(mutableListOf(ReplayFrame(File("1720693523997.jpg"), 1720693523997)))
             on { persistSegmentValues(any(), anyOrNull()) }.then {
                 persistedSegment.put(it.arguments[0].toString(), it.arguments[1]?.toString())
             }