Skip to content

Avoid stopping appStartProfiler after application creation #3630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stefanosiano merged 3 commits into from
Sep 3, 2024
Merged

Avoid stopping appStartProfiler after application creation #3630

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ede882
AppStartMetrics stops appStartProfiler only if no activity ever started
stefanosiano Aug 8, 2024
7016a16
updated changelog
stefanosiano Aug 8, 2024
7673c95
Merge branch 'main' into fix/app-start-profiler-avoid-stop
stefanosiano Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
AppStartMetrics stops appStartProfiler only if no activity ever started
  • Loading branch information
@stefanosiano
stefanosiano committed Aug 8, 2024
commit 8ede882a3b8fe31c32f192f5c731589dff683b75
11 changes: 6 additions & 5 deletions sentry-android-core/src/main/java/io/sentry/android/core/performance/AppStartMetrics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,13 +247,14 @@ public void registerApplicationForegroundCheck(final @NotNull Application applic
// if no activity has ever been created, app was launched in background
if (onCreateTime == null) {
appLaunchedInForeground = false;

// we stop the app start profiler, as it's useless and likely to timeout
if (appStartProfiler != null && appStartProfiler.isRunning()) {
appStartProfiler.close();
appStartProfiler = null;
}
}
application.unregisterActivityLifecycleCallbacks(instance);
// we stop the app start profiler, as it's useless and likely to timeout
if (appStartProfiler != null && appStartProfiler.isRunning()) {
appStartProfiler.close();
appStartProfiler = null;
}
});
}

Expand Down
14 changes: 14 additions & 0 deletions sentry-android-core/src/test/java/io/sentry/android/core/performance/AppStartMetricsTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,20 @@ class AppStartMetricsTest {
verify(profiler).close()
}

@Test
fun `if activity is started, does not stop app start profiler if running`() {
val profiler = mock<ITransactionProfiler>()
whenever(profiler.isRunning).thenReturn(true)
AppStartMetrics.getInstance().appStartProfiler = profiler
AppStartMetrics.getInstance().onActivityCreated(mock(), mock())

AppStartMetrics.getInstance().registerApplicationForegroundCheck(mock())
// Job on main thread checks if activity was launched
Shadows.shadowOf(Looper.getMainLooper()).idle()

verify(profiler, never()).close()
}

@Test
fun `if app start span is longer than 1 minute, appStartTimeSpanWithFallback returns an empty span`() {
val appStartTimeSpan = AppStartMetrics.getInstance().appStartTimeSpan
Expand Down