-
-
Notifications
You must be signed in to change notification settings - Fork 465
[SR] Add custom redaction options #3689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
2107b0c
Correctly infer text color for RN views
romtsn bee9697
Fix
romtsn a76e223
Add tests
romtsn 91e86ba
Formatting
romtsn c46fcc0
Changelog
romtsn 6e23fe5
wip
romtsn 3d5e837
Add custom redaction logic
romtsn 5727f28
Merge branch 'main' into rz/feat/session-replay-custom-redaction
romtsn fe15f79
revert
romtsn a660793
Add tests
romtsn e4ec640
Changelog
romtsn f434c56
redactClasses -> redactViewClasses
romtsn 504e855
Merge branch 'main' into rz/feat/session-replay-custom-redaction
romtsn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
wip
- Loading branch information
commit 6e23fe5b4847560751f883e9a8e52eb482b6b7ff
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| package io.sentry; | ||
|
|
||
| import io.sentry.protocol.SentryId; | ||
| import javax.swing.text.View; | ||
| import org.jetbrains.annotations.ApiStatus; | ||
| import org.jetbrains.annotations.NotNull; | ||
|
|
||
| @ApiStatus.Experimental | ||
| public class ReplayApi { | ||
|
|
||
| private final @NotNull ReplayController replayController; | ||
|
|
||
| public ReplayApi(final @NotNull ReplayController replayController) { | ||
| this.replayController = replayController; | ||
| } | ||
|
|
||
| public void start() { | ||
| replayController.start(); | ||
| } | ||
|
|
||
| public void stop() { | ||
| replayController.stop(); | ||
| } | ||
|
|
||
| public void pause() { | ||
| replayController.pause(); | ||
| } | ||
|
|
||
| public void resume() { | ||
| replayController.resume(); | ||
| } | ||
|
|
||
| public boolean isRecording() { | ||
| return replayController.isRecording(); | ||
| } | ||
|
|
||
| @NotNull | ||
| public SentryId getReplayId() { | ||
| return replayController.getReplayId(); | ||
| } | ||
|
|
||
| public void redactView(final @NotNull View view) { | ||
| replayController.redactView(view); | ||
| } | ||
|
|
||
| public void ignoreView(final @NotNull View view) { | ||
| replayController.ignoreView(view); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brustolin @bruno-garcia I guess we should align on naming here. Do you prefer this or
redactViewTypes? I'm fine with eitherThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should align but just Classes is too generic, what about "redactViewClasses"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, sounds good. I can also change it to
redactViewTypesso you don't have to :)