Skip to content

chore: Add action to warn about potentially risky PR changes #3726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stefanosiano merged 4 commits into from
Oct 15, 2024
Merged

chore: Add action to warn about potentially risky PR changes #3726

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
79df3b7
adds config+action to warn about risky PR changes
Sep 27, 2024
91c5f85
updates wording of warning PR comment
Sep 27, 2024
c1c8fef
added risky files
stefanosiano Oct 11, 2024
f2f03ee
Merge branch 'main' into kahest/high-risk-files
stefanosiano Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
updates wording of warning PR comment
  • Loading branch information
Karl Heinz Struggl committed Sep 27, 2024
commit 91c5f859759818c098b75cd6f203d6f3b91672f7
2 changes: 1 addition & 1 deletion .github/workflows/changes-in-high-risk-code.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,5 +45,5 @@ jobs:
issue_number: context.issue.number,
owner: context.repo.owner,
repo: context.repo.repo,
body: `### 🚨 Detected changes in high risk code 🚨 \n High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:\n ${fileList}`
body: `### 🚨 Detected changes in high risk code 🚨 \n High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:\n ${fileList}`
})