Skip to content

[QA] Replace Calendar.getInstance with System.currentTimeMillis for breadcrumb ctor #3736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
romtsn merged 8 commits into from
Oct 3, 2024
Merged

[QA] Replace Calendar.getInstance with System.currentTimeMillis for breadcrumb ctor #3736

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
78a7eb7
Replace Calendar getInstance with system currentTimeMillis for breadc…
romtsn Sep 30, 2024
4861467
Revert
romtsn Sep 30, 2024
01ebbf7
Merge branch 'main' into rz/fix/breadcrumb-date-ctor
markushi Oct 2, 2024
c2d497f
Keep Date getTImestamp for compatibility
romtsn Oct 2, 2024
3bdcf92
Changelog
romtsn Oct 2, 2024
663d6aa
Revert
romtsn Oct 2, 2024
e08f61f
Use getTimestamp()
romtsn Oct 2, 2024
e810349
Preserve Date passed in ctor
romtsn Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use getTimestamp()
  • Loading branch information
@romtsn
romtsn committed Oct 2, 2024
commit e08f61fd50d6a9ddf01daffaae3e8bcdcf2015bf
2 changes: 1 addition & 1 deletion sentry/src/main/java/io/sentry/Breadcrumb.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,7 +717,7 @@ public static final class JsonKeys {
public void serialize(final @NotNull ObjectWriter writer, final @NotNull ILogger logger)
throws IOException {
writer.beginObject();
writer.name(JsonKeys.TIMESTAMP).value(logger, DateUtils.getDateTime(timestamp));
writer.name(JsonKeys.TIMESTAMP).value(logger, getTimestamp());
if (message != null) {
writer.name(JsonKeys.MESSAGE).value(message);
}
Expand Down