Skip to content

[QA] Lazily load SentryOptions members #3749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
romtsn merged 13 commits into from
Oct 8, 2024
Merged

[QA] Lazily load SentryOptions members #3749

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
64a61fe
Make AtomicClientReportStorage constructor lazy
romtsn Oct 3, 2024
4210b0b
Lazily initialize things we dont need
romtsn Oct 3, 2024
79e8ce1
Empty experimental options
romtsn Oct 3, 2024
0511933
Format code
getsentry-bot Oct 3, 2024
209e60d
Merge branch 'main' into rz/anrs/lazy-client-reports
romtsn Oct 3, 2024
c8ea809
Make LazyEvaluator thread-safe
markushi Oct 8, 2024
02fd16f
Fix tests
markushi Oct 8, 2024
5ed2cfe
Fix .api
markushi Oct 8, 2024
b6f9dd0
Use LazyEvaluator for heavy SentryOptions
romtsn Oct 8, 2024
306add9
Changelog
romtsn Oct 8, 2024
d437823
revert
romtsn Oct 8, 2024
62f4168
tests
romtsn Oct 8, 2024
30ec7a2
Merge branch 'main' into rz/anrs/lazy-client-reports
romtsn Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix tests
  • Loading branch information
@markushi
markushi committed Oct 8, 2024
commit 02fd16fd95e4c845eb7f6d8ada842201065c5cd0
6 changes: 3 additions & 3 deletions sentry/src/test/java/io/sentry/SentryReplayOptionsTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ class SentryReplayOptionsTest {

@Test
fun `uses medium quality as default`() {
val replayOptions = SentryReplayOptions()
val replayOptions = SentryReplayOptions(true)

assertEquals(SentryReplayOptions.SentryReplayQuality.MEDIUM, replayOptions.quality)
assertEquals(75_000, replayOptions.quality.bitRate)
Expand All @@ -16,15 +16,15 @@ class SentryReplayOptionsTest {

@Test
fun `low quality`() {
val replayOptions = SentryReplayOptions().apply { quality = SentryReplayOptions.SentryReplayQuality.LOW }
val replayOptions = SentryReplayOptions(true).apply { quality = SentryReplayOptions.SentryReplayQuality.LOW }

assertEquals(50_000, replayOptions.quality.bitRate)
assertEquals(0.8f, replayOptions.quality.sizeScale)
}

@Test
fun `high quality`() {
val replayOptions = SentryReplayOptions().apply { quality = SentryReplayOptions.SentryReplayQuality.HIGH }
val replayOptions = SentryReplayOptions(true).apply { quality = SentryReplayOptions.SentryReplayQuality.HIGH }

assertEquals(100_000, replayOptions.quality.bitRate)
assertEquals(1.0f, replayOptions.quality.sizeScale)
Expand Down