Skip to content

[QA] Move NDK scope sync to background thread #3754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markushi merged 5 commits into from
Oct 14, 2024
Merged

[QA] Move NDK scope sync to background thread #3754

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b65ccd0
Move NDK scope sync to background thread
markushi Oct 4, 2024
cf412d4
Update Changelog
markushi Oct 4, 2024
7f701e5
Cleanup code
markushi Oct 4, 2024
9f71414
Merge branch 'main' into feat/async-ndk-scope-sync
markushi Oct 11, 2024
b3f16f7
Merge branch 'main' into feat/async-ndk-scope-sync
markushi Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Cleanup code
  • Loading branch information
@markushi
markushi committed Oct 4, 2024
commit 7f701e53e0ae8f23596aa2f29a40d9e0d65f61c2
28 changes: 4 additions & 24 deletions sentry-android-ndk/src/main/java/io/sentry/android/ndk/NdkScopeObserver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,12 +89,7 @@ public void addBreadcrumb(final @NotNull Breadcrumb crumb) {
@Override
public void setTag(final @NotNull String key, final @NotNull String value) {
try {
options
.getExecutorService()
.submit(
() -> {
nativeScope.setTag(key, value);
});
options.getExecutorService().submit(() -> nativeScope.setTag(key, value));
} catch (Throwable e) {
options.getLogger().log(SentryLevel.ERROR, e, "Scope sync setTag(%s) has an error.", key);
}
Expand All @@ -103,12 +98,7 @@ public void setTag(final @NotNull String key, final @NotNull String value) {
@Override
public void removeTag(final @NotNull String key) {
try {
options
.getExecutorService()
.submit(
() -> {
nativeScope.removeTag(key);
});
options.getExecutorService().submit(() -> nativeScope.removeTag(key));
} catch (Throwable e) {
options.getLogger().log(SentryLevel.ERROR, e, "Scope sync removeTag(%s) has an error.", key);
}
Expand All @@ -117,12 +107,7 @@ public void removeTag(final @NotNull String key) {
@Override
public void setExtra(final @NotNull String key, final @NotNull String value) {
try {
options
.getExecutorService()
.submit(
() -> {
nativeScope.setExtra(key, value);
});
options.getExecutorService().submit(() -> nativeScope.setExtra(key, value));
} catch (Throwable e) {
options.getLogger().log(SentryLevel.ERROR, e, "Scope sync setExtra(%s) has an error.", key);
}
Expand All @@ -131,12 +116,7 @@ public void setExtra(final @NotNull String key, final @NotNull String value) {
@Override
public void removeExtra(final @NotNull String key) {
try {
options
.getExecutorService()
.submit(
() -> {
nativeScope.removeExtra(key);
});
options.getExecutorService().submit(() -> nativeScope.removeExtra(key));
} catch (Throwable e) {
options
.getLogger()
Expand Down