Skip to content

[SR] Mask web and video views #3775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
romtsn merged 7 commits into from
Oct 8, 2024
Merged

[SR] Mask web and video views #3775

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d6ee508
Revert key frame interval to 10
romtsn Oct 8, 2024
6942db1
Add more masked classes by default
romtsn Oct 8, 2024
f7ade2d
Proguard rules
romtsn Oct 8, 2024
7116036
Changelog
romtsn Oct 8, 2024
0df0090
Change 10 to 6
romtsn Oct 8, 2024
dcb6dcb
Add exoplayer classes
romtsn Oct 8, 2024
d4b551f
formatting
romtsn Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Proguard rules
  • Loading branch information
@romtsn
romtsn committed Oct 8, 2024
commit f7ade2dfeb6f04ea6080adefaebf9594dd3fc8f8
3 changes: 3 additions & 0 deletions sentry-android-replay/proguard-rules.pro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,6 @@
# Rules to detect a compose view to parse its hierarchy
-dontwarn androidx.compose.ui.platform.AndroidComposeView
-keepnames class androidx.compose.ui.platform.AndroidComposeView
# Rules to detect a media player view to later mask it
-dontwarn androidx.media3.ui.PlayerView
-keepnames class androidx.media3.ui.PlayerView
4 changes: 2 additions & 2 deletions sentry/src/main/java/io/sentry/SentryReplayOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ public final class SentryReplayOptions {
public static final String IMAGE_VIEW_CLASS_NAME = "android.widget.ImageView";
public static final String WEB_VIEW_CLASS_NAME = "android.webkit.WebView";
public static final String VIDEO_VIEW_CLASS_NAME = "android.widget.VideoView";
public static final String EXOPLAYER_VIEW_CLASS_NAME = "androidx.media3.ui.PlayerView";
public static final String ANDROIDX_MEDIA_VIEW_CLASS_NAME = "androidx.media3.ui.PlayerView";

public enum SentryReplayQuality {
/** Video Scale: 80% Bit Rate: 50.000 */
Expand Down Expand Up @@ -104,7 +104,7 @@ public SentryReplayOptions() {
setMaskAllImages(true);
maskViewClasses.add(WEB_VIEW_CLASS_NAME);
maskViewClasses.add(VIDEO_VIEW_CLASS_NAME);
maskViewClasses.add(EXOPLAYER_VIEW_CLASS_NAME);
maskViewClasses.add(ANDROIDX_MEDIA_VIEW_CLASS_NAME);
}

public SentryReplayOptions(
Expand Down