Skip to content

[QA] Fix potential ANRs due to default integrations #3778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
romtsn merged 10 commits into from
Oct 9, 2024
Merged

[QA] Fix potential ANRs due to default integrations #3778

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d7e2ffc
Fix don't register any full drawn listeners if feature is not enabled
markushi Oct 8, 2024
fd2bc62
Offload app components breadcrumbs to background thread
markushi Oct 8, 2024
7561fe4
Offload system events breadcrumbs to background thread
markushi Oct 8, 2024
0870f09
Update Changelog
markushi Oct 8, 2024
e2cb750
Merge branch 'main' into feat/background-breadcrumbs
markushi Oct 8, 2024
4ffe903
Fix flaky tests
markushi Oct 9, 2024
41b11a9
Remove session breadcrumbs
markushi Oct 9, 2024
40cbfea
Fix tests
markushi Oct 9, 2024
0a924a0
Merge branch 'feat/background-breadcrumbs' of github.com:getsentry/se…
markushi Oct 9, 2024
e524d07
Address PR feedback
markushi Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix flaky tests
  • Loading branch information
@markushi
markushi committed Oct 9, 2024
commit 4ffe90320bb593eaf096c7c5ed52ccdc361d5b13
25 changes: 19 additions & 6 deletions ...roid-core/src/test/java/io/sentry/android/core/AppComponentsBreadcrumbsIntegrationTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,9 @@ class AppComponentsBreadcrumbsIntegrationTest {
@Test
fun `When app components breadcrumb is enabled, it registers callback`() {
val sut = fixture.getSut()
val options = SentryAndroidOptions()
val options = SentryAndroidOptions().apply {
executorService = ImmediateExecutorService()
}
val hub = mock<IHub>()
sut.register(hub, options)
verify(fixture.context).registerComponentCallbacks(any())
Expand All @@ -46,7 +48,9 @@ class AppComponentsBreadcrumbsIntegrationTest {
@Test
fun `When app components breadcrumb is enabled, but ComponentCallbacks is not ready, do not throw`() {
val sut = fixture.getSut()
val options = SentryAndroidOptions()
val options = SentryAndroidOptions().apply {
executorService = ImmediateExecutorService()
}
val hub = mock<IHub>()
sut.register(hub, options)
whenever(fixture.context.registerComponentCallbacks(any())).thenThrow(NullPointerException())
Expand All @@ -59,6 +63,7 @@ class AppComponentsBreadcrumbsIntegrationTest {
val sut = fixture.getSut()
val options = SentryAndroidOptions().apply {
isEnableAppComponentBreadcrumbs = false
executorService = ImmediateExecutorService()
}
val hub = mock<IHub>()
sut.register(hub, options)
Expand All @@ -68,7 +73,9 @@ class AppComponentsBreadcrumbsIntegrationTest {
@Test
fun `When AppComponentsBreadcrumbsIntegrationTest is closed, it should unregister the callback`() {
val sut = fixture.getSut()
val options = SentryAndroidOptions()
val options = SentryAndroidOptions().apply {
executorService = ImmediateExecutorService()
}
val hub = mock<IHub>()
sut.register(hub, options)
sut.close()
Expand All @@ -78,7 +85,9 @@ class AppComponentsBreadcrumbsIntegrationTest {
@Test
fun `When app components breadcrumb is closed, but ComponentCallbacks is not ready, do not throw`() {
val sut = fixture.getSut()
val options = SentryAndroidOptions()
val options = SentryAndroidOptions().apply {
executorService = ImmediateExecutorService()
}
val hub = mock<IHub>()
whenever(fixture.context.registerComponentCallbacks(any())).thenThrow(NullPointerException())
whenever(fixture.context.unregisterComponentCallbacks(any())).thenThrow(NullPointerException())
Expand Down Expand Up @@ -125,7 +134,9 @@ class AppComponentsBreadcrumbsIntegrationTest {
@Test
fun `When trim memory event with level not so high, do not add a breadcrumb`() {
val sut = fixture.getSut()
val options = SentryAndroidOptions()
val options = SentryAndroidOptions().apply {
executorService = ImmediateExecutorService()
}
val hub = mock<IHub>()
sut.register(hub, options)
sut.onTrimMemory(ComponentCallbacks2.TRIM_MEMORY_RUNNING_CRITICAL)
Expand All @@ -135,7 +146,9 @@ class AppComponentsBreadcrumbsIntegrationTest {
@Test
fun `When device orientation event, a breadcrumb with type, category and level should be set`() {
val sut = AppComponentsBreadcrumbsIntegration(ApplicationProvider.getApplicationContext())
val options = SentryAndroidOptions()
val options = SentryAndroidOptions().apply {
executorService = ImmediateExecutorService()
}
val hub = mock<IHub>()
sut.register(hub, options)
sut.onConfigurationChanged(mock())
Expand Down