Skip to content

Fix: Allow MaxBreadcrumb 0 / Expose MaxBreadcrumb metadata. #3836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stefanosiano merged 8 commits into from
Nov 4, 2024
Merged

Fix: Allow MaxBreadcrumb 0 / Expose MaxBreadcrumb metadata. #3836

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d282d06
expose max-breadcrumbs on meta data and implement disabled queue when…
Oct 30, 2024
4371e95
missing queue class and test
Oct 30, 2024
cc180a9
Merge branch 'main' into fix/0-breadcrumb
lucas-zimerman Oct 30, 2024
3e51f6c
update changelog
Oct 30, 2024
5f9ef0f
./gradlew :spotlessApply
Oct 30, 2024
a99280f
Merge branch 'main' into fix/0-breadcrumb
lucas-zimerman Oct 31, 2024
d581e91
Update sentry-android-core/src/test/java/io/sentry/android/core/Manif…
lucas-zimerman Nov 1, 2024
d0fa3b8
Update sentry-android-core/src/test/java/io/sentry/android/core/Manif…
lucas-zimerman Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update sentry-android-core/src/test/java/io/sentry/android/core/Manif… 
…estMetadataReaderTest.kt

Co-authored-by: Stefano <[email protected]>
  • Loading branch information
@lucas-zimerman @stefanosiano
lucas-zimerman and stefanosiano authored Nov 1, 2024
commit d0fa3b8f830ec1220203c6168dbc2c6f7a81dc5b
2 changes: 1 addition & 1 deletion sentry-android-core/src/test/java/io/sentry/android/core/ManifestMetadataReaderTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1517,7 +1517,7 @@ class ManifestMetadataReaderTest {
}

@Test
fun `applyMetadata reads maxbreadcrumb mask flags to options and sets the value if found`() {
fun `applyMetadata reads maxBreadcrumbs to options and sets the value if found`() {
// Arrange
val bundle = bundleOf(ManifestMetadataReader.MAX_BREADCRUMBS to 1)
val context = fixture.getContext(metaData = bundle)
Expand Down
Loading