Skip to content

Fix standalone tomcat jndi issue #3873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adinauer merged 5 commits into from
Nov 12, 2024
Merged

Fix standalone tomcat jndi issue #3873

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d08da1b
fix standalone tomcat jndi issue
lbloder Nov 11, 2024
1007e5b
format
lbloder Nov 11, 2024
fc6aed2
add changelog entry
lbloder Nov 11, 2024
0311245
adapt changelog
lbloder Nov 12, 2024
f1a2688
Merge branch 'main' into fix/spring-boot-tomcat-dsn
lbloder Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
format
  • Loading branch information
@lbloder
lbloder committed Nov 11, 2024
commit 1007e5bdb5cb7665ae48d11c77a2d6eeab55b41f
6 changes: 3 additions & 3 deletions sentry/src/main/java/io/sentry/SentryOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,9 +541,9 @@ public void addIntegration(@NotNull Integration integration) {
}

/**
* Evaluates and parses the DSN. May throw an exception if the DSN is invalid.
* Renamed from `getParsedDsn` as this would cause an error when deploying as WAR to
* Tomcat due to `JNDI` property binding.
* Evaluates and parses the DSN. May throw an exception if the DSN is invalid. Renamed from
* `getParsedDsn` as this would cause an error when deploying as WAR to Tomcat due to `JNDI`
* property binding.
*
* @return the parsed DSN or throws if dsn is invalid
*/
Expand Down
Loading