Skip to content

Avoid reading floats as ints from the manifest in case it's not necessary #4266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
romtsn merged 6 commits into from
Mar 19, 2025
Merged

Avoid reading floats as ints from the manifest in case it's not necessary #4266

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f4a4ef0
Avoid logging an error when a float is passed in the manifest
stefanosiano Jan 22, 2025
b47ea7c
Update CHANGELOG.md
markushi Mar 19, 2025
c48ad34
fix(session-replay): Do not crash if navigation breadcrumb has no de…
romtsn Feb 25, 2025
753b0fd
Merge branch '7.x.x' into markushi/fix/avoid-log-floats-7-x-x
romtsn Mar 19, 2025
9142663
Update CHANGELOG.md
romtsn Mar 19, 2025
12e46a4
Revert
romtsn Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Avoid logging an error when a float is passed in the manifest
  • Loading branch information
@stefanosiano @markushi
stefanosiano authored and markushi committed Mar 19, 2025
commit f4a4ef0b92318abc1066ac83a6b07544a7025327
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## Unreleased

### Fixes

- Avoid logging an error when a float is passed in the manifest ([#](https://github.com/getsentry/sentry-java/pull/))

## 7.22.3

### Fixes
Expand Down
5 changes: 4 additions & 1 deletion sentry-android-core/src/main/java/io/sentry/android/core/ManifestMetadataReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,10 @@ private static boolean readBool(
private static @NotNull Double readDouble(
final @NotNull Bundle metadata, final @NotNull ILogger logger, final @NotNull String key) {
// manifest meta-data only reads float
final Double value = ((Number) metadata.getFloat(key, metadata.getInt(key, -1))).doubleValue();
double value = ((Float) metadata.getFloat(key, -1)).doubleValue();
if (value == -1) {
value = ((Integer) metadata.getInt(key, -1)).doubleValue();
}
logger.log(SentryLevel.DEBUG, key + " read: " + value);
return value;
}
Expand Down
Loading