-
-
Notifications
You must be signed in to change notification settings - Fork 465
Handle RejectedExecutionException everywhere
#4747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c8125f3 | 397.65 ms | 485.14 ms | 87.49 ms |
| ee747ae | 386.94 ms | 431.43 ms | 44.49 ms |
| 23d6b12 | 354.10 ms | 408.38 ms | 54.28 ms |
| d217708 | 409.83 ms | 474.72 ms | 64.89 ms |
| d217708 | 411.22 ms | 430.86 ms | 19.63 ms |
| ee747ae | 400.46 ms | 423.61 ms | 23.15 ms |
| 17a0955 | 372.53 ms | 446.70 ms | 74.17 ms |
| 3d205d0 | 352.15 ms | 432.53 ms | 80.38 ms |
| 1df7eb6 | 397.04 ms | 429.64 ms | 32.60 ms |
| b750b96 | 408.98 ms | 480.32 ms | 71.34 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c8125f3 | 1.58 MiB | 2.10 MiB | 532.32 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| 23d6b12 | 1.58 MiB | 2.10 MiB | 532.31 KiB |
| d217708 | 1.58 MiB | 2.10 MiB | 532.97 KiB |
| d217708 | 1.58 MiB | 2.10 MiB | 532.97 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| 17a0955 | 1.58 MiB | 2.10 MiB | 533.20 KiB |
| 3d205d0 | 1.58 MiB | 2.10 MiB | 532.97 KiB |
| 1df7eb6 | 1.58 MiB | 2.10 MiB | 532.97 KiB |
| b750b96 | 1.58 MiB | 2.10 MiB | 533.19 KiB |
Previous results on branch: lcian/handle-rejected-execution-exception
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 922c01f | 374.10 ms | 411.06 ms | 36.96 ms |
| b8c9ebc | 395.56 ms | 451.02 ms | 55.46 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 922c01f | 1.58 MiB | 2.10 MiB | 533.33 KiB |
| b8c9ebc | 1.58 MiB | 2.10 MiB | 533.37 KiB |
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
markushi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sentry-android-core/src/main/java/io/sentry/android/core/DefaultAndroidEventProcessor.java
Show resolved
Hide resolved
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
adinauer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this!
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
📜 Description
RejectedExecutionExceptiononsubmitwhere it was previously unhandledWARNINGlevel everywhereSentryExecutorServicetothrows RejectedExecutionException(not sure if this is effective because it's aRuntimeExceptionanyway)submitmethod itself ofSentryExecutorService, but then we wouldn't throw it to the caller which can log a more specific messagedeviceInfoUtilto be nullable inDefaultAndroidEventProcessor. Upon accessing it, if it's null it will still trigger an NPE and log things likeoptions.getLogger().log(SentryLevel.ERROR, "Failed to retrieve device info", e);-> ended up changing it as described (with null checks)
💡 Motivation and Context
Closes: #4660
Closes: JAVA-144
💚 How did you test it?
All tests pass
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps