Skip to content

Start performance collection on AppStart continuous profiling #4752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stefanosiano merged 4 commits into from
Sep 29, 2025
Merged

Start performance collection on AppStart continuous profiling #4752

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4b08c5e
app start continuous profiler will now start performance collection w…
stefanosiano Sep 24, 2025
2e137a3
updated changelog
stefanosiano Sep 24, 2025
6991f6f
Merge branch 'main' into stefanosiano/fix/continuous-profiler-perform…
stefanosiano Sep 29, 2025
55e1f87
moved AppStartMetrics instance back before init stuff
stefanosiano Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
moved AppStartMetrics instance back before init stuff
  • Loading branch information
@stefanosiano
stefanosiano committed Sep 29, 2025
commit 55e1f87cafadb0c4d29da2618f94b4cdb260b1d5
3 changes: 2 additions & 1 deletion sentry-android-core/src/main/java/io/sentry/android/core/AndroidOptionsInitializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,8 @@ static void initializeIntegrationsAndProcessors(
options.setTransportGate(new AndroidTransportGate(options));
}

final @NotNull AppStartMetrics appStartMetrics = AppStartMetrics.getInstance();

if (options.getModulesLoader() instanceof NoOpModulesLoader) {
options.setModulesLoader(new AssetsModulesLoader(context, options.getLogger()));
}
Expand Down Expand Up @@ -248,7 +250,6 @@ static void initializeIntegrationsAndProcessors(
// Check if the profiler was already instantiated in the app start.
// We use the Android profiler, that uses a global start/stop api, so we need to preserve the
// state of the profiler, and it's only possible retaining the instance.
final @NotNull AppStartMetrics appStartMetrics = AppStartMetrics.getInstance();
final @Nullable ITransactionProfiler appStartTransactionProfiler;
final @Nullable IContinuousProfiler appStartContinuousProfiler;
try (final @NotNull ISentryLifecycleToken ignored = AppStartMetrics.staticLock.acquire()) {
Expand Down
Loading