feat: Deprecate and noop cleanArtifacts
#525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
approved these changes
Apr 17, 2024
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
yeah let's just noop here, sounds reasonable!
Co-authored-by: Lukas Stracke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cleanArtifactswas historically needed to remove artifacts before uploading to avoid collisions. Since Sentry can nowadays accept multiple artifacts with the same name per release and prefer the most recent one this option is unnecessary.Additionally, it causes problems like these: #481 with org auth tokens so moving forward it should noop.