misc(esbuild): Log warning when attempting to inject debug IDs with esbuild bundle option active
#526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sbuild `bundle` option active
Lms24
reviewed
Apr 17, 2024
packages/esbuild-plugin/src/index.ts
Outdated
| setup({ initialOptions, onLoad, onResolve }) { | ||
| if (initialOptions.bundle) { | ||
| logger.warn( | ||
| "Esbuild's `bundle` option is currently not supported! Esbuild will probably crash now." |
Member
There was a problem hiding this comment.
l: Did I understand the issue correctly that this only happens for bundle: true? In this case, maybe we tell users this specifically:
Suggested change
| "Esbuild's `bundle` option is currently not supported! Esbuild will probably crash now." | |
| "Esbuild's `bundle: true` option is currently not supported! Esbuild will probably crash now." |
Also, is there anything we can recommend them here instead of just saying that their build will crash?
Author
There was a problem hiding this comment.
Absolutely valid point. I updated the wording!
Author
|
@Lms24 would you mind taking another look? |
Lms24
approved these changes
May 3, 2024
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
Whoops, sorry this fell through. LGTM and thx for making the change!
I'm confused here cc @lforst |
Author
|
omg I think I completely flipped what I meant to do in that PR. Gonna fix it on monday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: #445 (comment)