Skip to content

feat(node): Use @opentelemetry/instrumentation-undici for fetch tracing #13485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AbhiPrasad merged 21 commits into from
Sep 9, 2024
Merged

feat(node): Use @opentelemetry/instrumentation-undici for fetch tracing #13485

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
dbd4ed8
feat(node): Use `@opentelemetry/instrumentation-undici` for fetch tra…
timfish Aug 27, 2024
eb0a361
Merge remote-tracking branch 'upstream/develop' into timfish/otel-undici
timfish Sep 2, 2024
15b856c
revert mongoose bump
timfish Sep 2, 2024
f94e183
Manually set `SEMATTRS_HTTP_URL` (`http.url`) since the instrumentati…
timfish Sep 2, 2024
7342e61
add comments
timfish Sep 2, 2024
5d2d0f2
fix baggage propagation
timfish Sep 2, 2024
4fa38f3
Lint
timfish Sep 3, 2024
4368628
Check `url.full`
timfish Sep 3, 2024
6b3adb3
Merge branch 'develop' into timfish/otel-undici
timfish Sep 3, 2024
2e621b2
Fix attribute
timfish Sep 4, 2024
0db9814
Merge remote-tracking branch 'upstream/develop' into timfish/otel-undici
timfish Sep 4, 2024
df01350
Get tests passing!
timfish Sep 5, 2024
cc873d8
Merge branch 'develop' into timfish/otel-undici
timfish Sep 5, 2024
033a154
lint
timfish Sep 5, 2024
7545513
Dont test Node v16
timfish Sep 5, 2024
88728a1
more `http.request.method`
timfish Sep 5, 2024
0cb3322
Fix nextjs-14 e2e test
timfish Sep 5, 2024
4a73857
From PR review
timfish Sep 5, 2024
e8e2198
Fix nextjs-14 test
timfish Sep 5, 2024
8bb6c75
Merge remote-tracking branch 'upstream/develop' into timfish/otel-undici
timfish Sep 5, 2024
049d328
Merge branch 'develop' into timfish/otel-undici
timfish Sep 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Dont test Node v16
  • Loading branch information
@timfish
timfish committed Sep 5, 2024
commit 75455130dd71f573272ca73d3a0e53eec8a59512
2 changes: 1 addition & 1 deletion dev-packages/node-integration-tests/suites/tracing/requests/fetch-no-tracing/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { conditionalTest } from '../../../../utils';
import { createRunner } from '../../../../utils/runner';
import { createTestServer } from '../../../../utils/server';

conditionalTest({ min: 16 })('outgoing fetch', () => {
conditionalTest({ min: 18 })('outgoing fetch', () => {
test('outgoing fetch requests are correctly instrumented with tracing disabled', done => {
expect.assertions(11);

Expand Down
2 changes: 1 addition & 1 deletion ...kages/node-integration-tests/suites/tracing/requests/fetch-sampled-no-active-span/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { conditionalTest } from '../../../../utils';
import { createRunner } from '../../../../utils/runner';
import { createTestServer } from '../../../../utils/server';

conditionalTest({ min: 16 })('outgoing fetch', () => {
conditionalTest({ min: 18 })('outgoing fetch', () => {
test('outgoing sampled fetch requests without active span are correctly instrumented', done => {
expect.assertions(11);

Expand Down
2 changes: 1 addition & 1 deletion dev-packages/node-integration-tests/suites/tracing/requests/fetch-unsampled/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { conditionalTest } from '../../../../utils';
import { createRunner } from '../../../../utils/runner';
import { createTestServer } from '../../../../utils/server';

conditionalTest({ min: 16 })('outgoing fetch', () => {
conditionalTest({ min: 18 })('outgoing fetch', () => {
test('outgoing fetch requests are correctly instrumented when not sampled', done => {
expect.assertions(11);

Expand Down