Skip to content

fix(feedback): Return when the sendFeedback promise resolves #14683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lforst merged 4 commits into from
Dec 13, 2024
Merged

fix(feedback): Return when the sendFeedback promise resolves #14683

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5eb1144
Return when the sendFeedback promise resolves
antonis Dec 12, 2024
7dfcbb4
Adds changelog
antonis Dec 12, 2024
30efbb4
rm changelog entry
Dec 12, 2024
ed62a1e
Merge branch 'develop' into fix/sendFeedback-resolve
billyvg Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Return when the sendFeedback promise resolves
  • Loading branch information
@antonis
antonis committed Dec 12, 2024
commit 5eb11442c604fc56bed432a457458159feb93aba
2 changes: 1 addition & 1 deletion packages/feedback/src/core/sendFeedback.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export const sendFeedback: SendFeedback = (
response.statusCode >= 200 &&
response.statusCode < 300
) {
resolve(eventId);
return resolve(eventId);
}

if (response && typeof response.statusCode === 'number' && response.statusCode === 0) {
Expand Down