Skip to content

fix: Normalise ANR debug image file paths if appRoot was supplied [v8] #14709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AbhiPrasad merged 2 commits into from
Dec 16, 2024
Merged

fix: Normalise ANR debug image file paths if appRoot was supplied [v8] #14709

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1a1ae8
fix: Normalise ANR debug image file paths if appRoot was supplied
timfish Dec 13, 2024
b30f035
Merge branch 'v8' into timfish/fix/anr-debug-meta-normalise
AbhiPrasad Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: Normalise ANR debug image file paths if appRoot was supplied
  • Loading branch information
@timfish
timfish committed Dec 13, 2024
commit c1a1ae8b9202bb15336d991eb9bac9c7640e7935
8 changes: 5 additions & 3 deletions packages/node/src/integrations/anr/worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,11 +104,13 @@ function applyDebugMeta(event: Event): void {

if (filenameToDebugId.size > 0) {
const images: DebugImage[] = [];
for (const [filename, debugId] of filenameToDebugId.entries()) {
for (const [filename, debug_id] of filenameToDebugId.entries()) {
const code_file = options.appRootPath ? normalizeUrlToBase(filename, options.appRootPath) : filename;

images.push({
type: 'sourcemap',
code_file: filename,
debug_id: debugId,
code_file,
debug_id,
});
}
event.debug_meta = { images };
Expand Down
Loading