Skip to content

feat(v8/sveltekit): Deprecate fetchProxyScriptNonce option #15011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lms24 merged 2 commits into from
Jan 22, 2025
Merged

feat(v8/sveltekit): Deprecate fetchProxyScriptNonce option #15011

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe35dd9
feat(sveltekit): Deprecate fetch proxy script options
Lms24 Jan 14, 2025
c109088
undeprecate injectFetchProxyScript
Lms24 Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
undeprecate injectFetchProxyScript
  • Loading branch information
@Lms24
Lms24 committed Jan 21, 2025
commit c109088372445ceb8e2e2cfca017b416c3cd995e
18 changes: 8 additions & 10 deletions packages/sveltekit/src/server/handle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,27 +40,25 @@ export type SentryHandleOptions = {
* Controls if `sentryHandle` should inject a script tag into the page that enables instrumentation
* of `fetch` calls in `load` functions.
*
* @default true
* You can safely set this to `false` if you're using `@sveltejs/kit` version 2.16.0 or newer. This
* is only needed for versions older than 2.16.0.
*
* @deprecated This option will be removed in the next major version of the SDK. There's no replacement as the fetch
* proxy script will no longer be added to the page response.
* @default true
*/
injectFetchProxyScript?: boolean;

/**
* Warning: This option is <b>strongly discouraged</b> to be used and will be removed in the next major version of the SDK.
* Warning: Setting this option is **strongly discouraged** and it will be removed in the next major version of the SDK.
*
* If you set this option, the passed nonce will be added to fetch proxy `<script>` tag that the Sentry SDK adds to your page.
* The nonce passed to this option will be reused across multiple requests, which is defeating the purpose of a nonce.
* See below for options what to do instead.
*
* @deprecated This option will be removed in the next major version of the SDK. There's no replacement as the fetch
* proxy script will no longer be added to the page response.
* @deprecated This option will be removed in the next major version of the SDK.
*
* Until then, you have the following options:
* - set a hash of the nonce in the CSP header instead as documented [in our docs]()
* - update `@sveltejs/kit` to at least version 1.26.0 or newer and set `injectFetchProxyScript: false`
* - continue to use this option but we strongly advise against it!
* If you rely on this option, you have the following replacement options:
* - set a hash instead of the nonce in your CSP config [as documented here](https://docs.sentry.io/platforms/javascript/guides/sveltekit/manual-setup/#configure-csp-for-client-side-fetch-instrumentation)
* - update `@sveltejs/kit` to at least version 2.16.0 or newer and set `injectFetchProxyScript: false`
*/
fetchProxyScriptNonce?: string;
};
Expand Down
Loading