Skip to content

ref(browser): Add protocol attributes to resource spans #15161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lms24 merged 4 commits into from
Jan 29, 2025
Merged

ref(browser): Add protocol attributes to resource spans #15161

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fcbbe45
ref(browser): Add protocol metadata to resource spans
Zen-cronic Jan 26, 2025
87932e7
refactor unit tests, strengthen integration test
Lms24 Jan 27, 2025
49ac3b2
formatting
Lms24 Jan 27, 2025
b75eb03
fix for webkit integration test run
Lms24 Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
formatting
  • Loading branch information
@Lms24
Lms24 committed Jan 28, 2025
commit 49ac3b2f1a1addbd3f3a7bf4fa8fee5072087515
8 changes: 4 additions & 4 deletions ...packages/browser-integration-tests/suites/tracing/metrics/pageload-resource-spans/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import type { Route } from '@playwright/test';
import { expect } from '@playwright/test';
import { SEMANTIC_ATTRIBUTE_SENTRY_OP, SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN, type Event } from '@sentry/core';
import { type Event, SEMANTIC_ATTRIBUTE_SENTRY_OP, SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN } from '@sentry/core';

import { sentryTest } from '../../../../utils/fixtures';
import { getFirstSentryEnvelopeRequest, shouldSkipTracingTest } from '../../../../utils/helpers';
Expand Down Expand Up @@ -74,7 +74,7 @@ sentryTest('should add resource spans to pageload transaction', async ({ getLoca
'http.response_content_length': expect.any(Number),
'http.response_delivery_type': '',
'http.response_transfer_size': expect.any(Number),
'network.protocol.name': 'unknown',
'network.protocol.name': '',
'network.protocol.version': 'unknown',
'resource.render_blocking_status': 'non-blocking',
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'resource.img',
Expand All @@ -99,7 +99,7 @@ sentryTest('should add resource spans to pageload transaction', async ({ getLoca
'http.response_content_length': expect.any(Number),
'http.response_delivery_type': '',
'http.response_transfer_size': expect.any(Number),
'network.protocol.name': 'unknown',
'network.protocol.name': '',
'network.protocol.version': 'unknown',
'resource.render_blocking_status': 'non-blocking',
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'resource.link',
Expand All @@ -124,7 +124,7 @@ sentryTest('should add resource spans to pageload transaction', async ({ getLoca
'http.response_content_length': expect.any(Number),
'http.response_delivery_type': '',
'http.response_transfer_size': expect.any(Number),
'network.protocol.name': 'unknown',
'network.protocol.name': '',
'network.protocol.version': 'unknown',
'resource.render_blocking_status': 'non-blocking',
'sentry.op': 'resource.script',
Expand Down