Skip to content

fix(v8/react): From location can be undefined in Tanstack Router Instrumentation #15237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lms24 merged 3 commits into from
Jan 31, 2025
Merged

fix(v8/react): From location can be undefined in Tanstack Router Instrumentation #15237

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
09a3f36
fix(react): From location can be undefined in Tanstack Router Instrum…
tannerlinsley Jan 30, 2025
af58f35
ref(react): Adapt tanstack router type
mydea Jan 31, 2025
7a2561b
avoid optional chaining
Lms24 Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(react): From location can be undefined in Tanstack Router Instrum… 
…entation (#15235)

fixes #15234

Due to a big bug in TanStack Router getting fixed, this needs an
optional chain to not die.
  • Loading branch information
@tannerlinsley @Lms24
tannerlinsley authored and Lms24 committed Jan 31, 2025
commit 09a3f36d47379aedea2599435ddebe3f828d5166
2 changes: 1 addition & 1 deletion packages/react/src/tanstackrouter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ export function tanstackRouterBrowserTracingIntegration(
// The onBeforeNavigate hook is called at the very beginning of a navigation and is only called once per navigation, even when the user is redirected
castRouterInstance.subscribe('onBeforeNavigate', onBeforeNavigateArgs => {
// onBeforeNavigate is called during pageloads. We can avoid creating navigation spans by comparing the states of the to and from arguments.
if (onBeforeNavigateArgs.toLocation.state === onBeforeNavigateArgs.fromLocation.state) {
if (onBeforeNavigateArgs.toLocation.state === onBeforeNavigateArgs.fromLocation?.state) {
return;
}

Expand Down
Loading