Skip to content

feat(svelte)!: Disable component update tracking by default #15265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lms24 merged 6 commits into from
Feb 4, 2025
Merged

feat(svelte)!: Disable component update tracking by default #15265

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b7135cb
fix(v8/svelte): Guard component tracking `beforeUpdate` call
Lms24 Feb 3, 2025
b340082
feat(svelte)!: Disable component update tracking by default
Lms24 Feb 3, 2025
113cbc3
fix tests
Lms24 Feb 4, 2025
b307f15
fix tests for real
Lms24 Feb 4, 2025
71d307d
syntax error
Lms24 Feb 4, 2025
b7289ef
...
Lms24 Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
...
  • Loading branch information
@Lms24
Lms24 committed Feb 4, 2025
commit b7289ef7cd080773146f447220d4092942f54e0d
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/test-applications/sveltekit-2/src/routes/components/Component2.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import Component3 from "./Component3.svelte";
import {trackComponent} from '@sentry/sveltekit';

trackComponent({componentName: 'Component2', trackUpdates: true, trackUpdates: true});
trackComponent({componentName: 'Component2', trackUpdates: true});
</script>
<h3>Howdy, I'm component 2</h3>

Expand Down
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/test-applications/sveltekit-2/src/routes/components/Component3.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<script lang="ts">
import * as Sentry from '@sentry/sveltekit';
Sentry.trackComponent({componentName: 'Component3'});
Sentry.trackComponent({componentName: 'Component3', trackUpdates: true});
</script>

<h3>Howdy, I'm component 3</h3>
Loading