Skip to content

feat(core): Add links to span options #15453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
s1gr1d merged 4 commits into from
Feb 24, 2025
Merged

feat(core): Add links to span options #15453

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce4bf71
feat(core): Add `addLink(s)` to Sentry span
s1gr1d Feb 20, 2025
82c5a34
feat(core): Add links to span options
s1gr1d Feb 20, 2025
7b3ce17
Merge branch 'refs/heads/develop' into sig/links-spanOptions
s1gr1d Feb 24, 2025
2f7a252
use `waitForTransactionRequest`
s1gr1d Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
use waitForTransactionRequest
  • Loading branch information
@s1gr1d
s1gr1d committed Feb 24, 2025
commit 2f7a252055fb3a382982b4fc81b9b663dd6acc8e
14 changes: 11 additions & 3 deletions dev-packages/browser-integration-tests/suites/tracing/linking-spanOptions/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,23 @@
import { expect } from '@playwright/test';
import type { Event } from '@sentry/core';
import type { TransactionEvent } from '@sentry/core';
import { sentryTest } from '../../../utils/fixtures';
import { getMultipleSentryEnvelopeRequests, shouldSkipTracingTest } from '../../../utils/helpers';
import { envelopeRequestParser, shouldSkipTracingTest, waitForTransactionRequest } from '../../../utils/helpers';

sentryTest('should link spans by adding "links" to span options', async ({ getLocalTestUrl, page }) => {
if (shouldSkipTracingTest()) {
sentryTest.skip();
}

const rootSpan1Promise = waitForTransactionRequest(page, event => event.transaction === 'rootSpan1');
const rootSpan2Promise = waitForTransactionRequest(page, event => event.transaction === 'rootSpan2');
const rootSpan3Promise = waitForTransactionRequest(page, event => event.transaction === 'rootSpan3');

const url = await getLocalTestUrl({ testDir: __dirname });
const [rootSpan1, rootSpan2, rootSpan3] = await getMultipleSentryEnvelopeRequests<Event>(page, 3, { url });
await page.goto(url);

const rootSpan1 = envelopeRequestParser<TransactionEvent>(await rootSpan1Promise);
const rootSpan2 = envelopeRequestParser<TransactionEvent>(await rootSpan2Promise);
const rootSpan3 = envelopeRequestParser<TransactionEvent>(await rootSpan3Promise);

const rootSpan1_traceId = rootSpan1.contexts?.trace?.trace_id as string;
const rootSpan1_spanId = rootSpan1.contexts?.trace?.span_id as string;
Expand Down
Loading