Skip to content

feat: Stop using dropUndefinedKeys #15796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mydea merged 5 commits into from
Mar 25, 2025
Merged

feat: Stop using dropUndefinedKeys #15796

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d2dffac
ref: Refactor some more `dropUndefinedKeys`
mydea Mar 24, 2025
3347fa5
avoid more work??
mydea Mar 24, 2025
0869503
fixes
mydea Mar 24, 2025
850f1bb
deprecate it..
mydea Mar 24, 2025
759bf76
small test fixes
mydea Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
small test fixes
  • Loading branch information
@mydea
mydea committed Mar 24, 2025
commit 759bf76ac69f4a25b29ebc03423adf6ab1bd8446
3 changes: 3 additions & 0 deletions packages/browser/test/tracing/browserTracingIntegration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -728,6 +728,7 @@ describe('browserTracingIntegration', () => {
sampled: true,
sampleRand: expect.any(Number),
dsc: {
release: undefined,
environment: 'production',
public_key: 'examplePublicKey',
sample_rate: '1',
Expand Down Expand Up @@ -768,6 +769,7 @@ describe('browserTracingIntegration', () => {
sampled: false,
sampleRand: expect.any(Number),
dsc: {
release: undefined,
environment: 'production',
public_key: 'examplePublicKey',
sample_rate: '0',
Expand Down Expand Up @@ -892,6 +894,7 @@ describe('browserTracingIntegration', () => {

expect(dynamicSamplingContext).toBeDefined();
expect(dynamicSamplingContext).toStrictEqual({
release: undefined,
environment: 'production',
public_key: 'examplePublicKey',
sample_rate: '1',
Expand Down
Loading